Skip to content

tear_down for train extensions; fixes #1467 #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tear_down for train extensions; fixes #1467 #1502

wants to merge 1 commit into from

Conversation

TNick
Copy link
Contributor

@TNick TNick commented Apr 26, 2015

Train main loop is wrapped in a try-catch block.
LiveMonitoring now uses setup() to open the ports and tear_down() to close them.

@lamblin
Copy link
Member

lamblin commented May 6, 2015

Thanks for the PR.
Unfortunately, I was not able to review it in time, and you will have to rebase it, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TNick @lamblin