add v2 support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Add SPDX-License-Identifier for all existing codes. Fixes: levex#2 Signed-off-by: bin liu <[email protected]>
add SPDX-License-Identifier for all source
Signed-off-by: bin liu <[email protected]>
liubin
commented
Sep 8, 2020
src/blkio.rs
Outdated
| let mut content = format!("{}:{} {}", major, minor, iops); | ||
| if self.v2 { | ||
| file = "io.max"; | ||
| content = format!("{}:{} riops={}", major, minor, iops); |
liubin
commented
Sep 8, 2020
| let mut file = "blkio.weight_device"; | ||
| if self.v2 { | ||
| // FIXME why is there no weight for device in runc ? | ||
| // https://github.com/opencontainers/runc/blob/46be7b612e2533c494e6a251111de46d8e286ed5/libcontainer/cgroups/fs2/io.go#L30 |
There was a problem hiding this comment.
好像跟 io 调度算法有关 。https://wiki.ubuntu.com/Kernel/Reference/IOSchedulers
liubin
commented
Sep 8, 2020
tests/devices.rs
Outdated
|
|
||
| #[test] | ||
| fn test_devices_parsing() { | ||
| let hier = cgroups::hierarchies::V1::new(); | ||
| let cg = Cgroup::new(&hier, String::from("test_devices_parsing")); | ||
| // no only v2 |
liubin
commented
Sep 8, 2020
tests/hugetlb.rs
Outdated
|
|
||
| #[test] | ||
| fn test_hugetlb_sizes() { | ||
| // no only v2 |
lifupan
reviewed
Sep 8, 2020
src/blkio.rs
Outdated
| fn apply(&self, res: &Resources) -> Result<()> { | ||
| // get the resources that apply to this controller | ||
| let res: &BlkIoResources = &res.blkio; | ||
|
|
||
| if res.update_values { | ||
| let _ = self.set_weight(res.weight as u64); | ||
| let _ = self.set_leaf_weight(res.leaf_weight as u64); | ||
| if res.weight.is_some() { |
There was a problem hiding this comment.
这个地方的几个 判断 is_some 的句式 改成下面的样子吧：
if let Some(weight) = res.weight {
let _ = self.set_weight(weight as u64);
}
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
Signed-off-by: bin liu <[email protected]>
add cgroup v2 support
cfs_quota can be set to -1 to indicate no limit Fixes: levex#5 Signed-off-by: bin liu <[email protected]>
Errors cause should be shared to let anyhow to wrap it. Fixes: levex#7 Signed-off-by: bin liu <[email protected]>
cpu: change cfs_quota from u64 to i64
…-cause errors: add sync marker to error cause
c_char is equal to i8 on x86, but it is equal to u8 on arm arch, so we need to use type c_char instead of i8 to avoid compiling error. Fixes: levex#9 Signed-off-by: zhanghj <[email protected]>
…-aarch64 lib: fix compiling error for type i8 in aarch64 environment
Fixes: levex#11 Signed-off-by: bin liu <[email protected]>
update Travis configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.