Uplift AI TTS #712

zaidqureshi2 · 2025-09-19T07:58:28Z

Description

Added a TTS client for Uplift AI TTS, which uses websockets do provide streaming inference. Also added an example agent using it.

Changes Made

Added upliftai plugin (new, recently added on in python side too)
Non related Added .claude to gitignore

Pre-Review Checklist

Build passes: All builds (lint, typecheck, tests) pass locally
AI-generated code reviewed: Removed unnecessary comments and ensured code quality
Changes explained: All changes are properly documented and justified above
Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included

Testing

Automated tests added/updated (if applicable)
All tests pass
Make sure both restaurant_agent.ts and realtime_agent.ts work properly (for major changes)

Additional Notes

Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.

changeset-bot · 2025-09-19T07:58:33Z

⚠️ No Changeset found

Latest commit: 018f365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

plugins/upliftai/src/tts.ts

toubatbrian · 2025-09-22T12:54:34Z

plugins/upliftai/src/tts.ts

+  #apiKey: string;
+  #baseURL: string;
+  #voiceSettings: VoiceSettings;
+  #tokenizer: tokenize.WordTokenizer | tokenize.SentenceTokenizer;
+  #client: WebSocketClient | null = null;
+  #logger = log();
+  #chunkTimeout: number;


I'd suggest using private instead of #. cc @Shubhrakanti let me know your thoughts

yeah lets use private

I can definitely remove them, but was following the convention on all the other tts.ts stt.ts files for other providers, they seem to be using # for all the private variables. Please let me know if I should still remove and replace with private.

yeah that's out dated let's use private

toubatbrian · 2025-09-22T12:58:49Z

plugins/upliftai/src/tts.ts

+  #apiKey: string;
+  #baseURL: string;
+  #voiceSettings: VoiceSettings;
+  #tokenizer: tokenize.WordTokenizer | tokenize.SentenceTokenizer;
+  #client: WebSocketClient | null = null;
+  #logger = log();
+  #chunkTimeout: number;
+  label = 'upliftai.SynthesizeStream';


toubatbrian

Added a few small comments, otherwise LGTM!

Shubhrakanti

Have you tested this manually with interrupts?

Shubhrakanti · 2025-09-23T16:04:52Z

.gitignore

-examples/src/test_*.ts
+examples/src/test_*.ts
+
+.claude


Shubhrakanti · 2025-09-23T16:05:43Z

turbo.json

-    "GOOGLE_CLOUD_LOCATION"
+    "GOOGLE_CLOUD_LOCATION",
+    "UPLIFTAI_API_KEY",
+    "UPLIFTAI_BASE_URL"


why does this need to be parameterized as an env variable? This can just be defined in code with a default in the class constructor?

will remove, its in the constructor as well.

Shubhrakanti · 2025-09-23T16:06:30Z

plugins/upliftai/src/tts.ts

+  #apiKey: string;
+  #baseURL: string;
+  #voiceSettings: VoiceSettings;
+  #tokenizer: tokenize.WordTokenizer | tokenize.SentenceTokenizer;
+  #client: WebSocketClient | null = null;
+  #logger = log();
+  #chunkTimeout: number;


yeah lets use private

zaidqureshi2 · 2025-09-23T16:27:09Z

Have you tested this manually with interrupts?

@Shubhrakanti created a quick loom to show interrupts https://www.loom.com/share/b57500b58a994fd386134240705cdbc2

zaidqureshi2 · 2025-09-27T14:41:17Z

@Shubhrakanti & @toubatbrian lmk what your thoughts are on my comments before I push next revision

toubatbrian · 2025-10-07T18:11:12Z

Hey @zaidqureshi2 sorry for the late reply, the loom seems not working. Could you please make a new link? Thanks

zaidqureshi2 force-pushed the main branch from f830006 to 99b0bc2 Compare September 19, 2025 08:04

zaidqureshi2 added 2 commits September 19, 2025 15:59

Uplift AI TTS

6dcb24c

update pnpm lock file

018f365

zaidqureshi2 force-pushed the main branch from 99b0bc2 to 018f365 Compare September 19, 2025 11:59

mike-r-mclaughlin requested review from Shubhrakanti and toubatbrian September 20, 2025 11:09

toubatbrian reviewed Sep 22, 2025

View reviewed changes

plugins/upliftai/src/tts.ts Show resolved Hide resolved

toubatbrian reviewed Sep 22, 2025

View reviewed changes

Shubhrakanti reviewed Sep 23, 2025

View reviewed changes

Uplift AI TTS #712

Are you sure you want to change the base?

Uplift AI TTS #712

Uh oh!

Conversation

zaidqureshi2 commented Sep 19, 2025

Description

Changes Made

Pre-Review Checklist

Testing

Additional Notes

Uh oh!

changeset-bot bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toubatbrian left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhrakanti left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaidqureshi2 commented Sep 23, 2025

Uh oh!

zaidqureshi2 commented Sep 27, 2025

Uh oh!

toubatbrian commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Sep 19, 2025 •

edited

Loading