Skip to content

Conversation

@Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 20, 2025

split off from #609

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 20, 2025

tokio-rustls 0.24 has been dragging in an old rustls 0.21.12 in addition to the rustls 0.23 used by the rest of the dependency tree 🙈

@Be-ing Be-ing force-pushed the tokio_tungstenite_update branch from 0245805 to 85b27d5 Compare October 20, 2025 03:29
@ladvoc ladvoc mentioned this pull request Oct 21, 2025
@ladvoc
Copy link
Contributor

ladvoc commented Oct 21, 2025

Currently, E2E tests in CI run with a local SFU in dev mode without TLS. In order to make sure this doesn't break anything, we need to verify E2E tests pass with a LiveKit Cloud SFU and the rustls-tls-native-roots feature enabled:

LIVEKIT_URL=wss://my-project.livekit.cloud \
LIVEKIT_API_KEY=xxx \
LIVEKIT_API_SECRET=xxx \
cargo test --features rustls-tls-native-roots,__lk-e2e-test -- --nocapture

I'm going to look into what the issue is here, but currently, I get the following runtime error when running E2E tests with TLS:

Could not automatically determine the process-level CryptoProvider from Rustls crate features.
Call CryptoProvider::install_default() before this point to select a provider manually, or make sure exactly one of the 'aws-lc-rs' and 'ring' features is enabled. See the documentation of the CryptoProvider type for more information.

@ladvoc
Copy link
Contributor

ladvoc commented Oct 21, 2025

@Be-ing Be-ing force-pushed the tokio_tungstenite_update branch from 85b27d5 to b20c668 Compare October 21, 2025 03:14
@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 21, 2025

I think this is the issue: rustls/rustls#1938 (comment)

I think so. livekit-api's rustls-tls-native-roots feature activates reqwest's rustls-tls-native-roots feature, which activates reqwest's __rustls_ring feature, which activates the ring feature of rustls. I think this was not causing a problem before because of the separate old version of rustls being used by livekit-api.

@Be-ing
Copy link
Contributor Author

Be-ing commented Oct 24, 2025

@ladvoc any thoughts how to resolve this?

@ladvoc
Copy link
Contributor

ladvoc commented Oct 24, 2025

Let me take a closer look and get back to you on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants