feat: Add DisableRed option for audio publications
#708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, though I don't think the option is relevant for the SDK at the moment. Any audio that is published is either encoded by the user, or encoded using the PCM track APIs (which does not use RED). The option is relevant for SDKs that support encoding/decoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
DisableRedoption toTrackPublicationOptions. This allows developers to disable Redundant Audio Data (RED) for an audio track upon publication.While RED can improve audio resilience on networks with packet loss, it increases bandwidth usage. This option provides flexibility for scenarios where lower bandwidth is a priority.