Skip to content

Conversation

@j0sh
Copy link
Collaborator

@j0sh j0sh commented Oct 21, 2025

This supports IPv6 addresses which have multiple colons like [::1]:57579

Discovered while testing with my new laptop which apparently uses IPv6 over localhost.

This supports IPv6 addresses which have multiple colons like [::1]:57579
@j0sh j0sh requested review from leszko, mjh1 and victorges October 21, 2025 23:31
@github-actions github-actions bot added the go Pull requests that update Go code label Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.53858%. Comparing base (9c49266) to head (b36abbb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3790         +/-   ##
===================================================
+ Coverage   31.53331%   31.53858%   +0.00527%     
===================================================
  Files            159         159                 
  Lines          38981       38984          +3     
===================================================
+ Hits           12292       12295          +3     
  Misses         25799       25799                 
  Partials         890         890                 
Files with missing lines Coverage Δ
server/mediaserver.go 68.14745% <100.00000%> (+0.28015%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c49266...b36abbb. Read the comment docs.

Files with missing lines Coverage Δ
server/mediaserver.go 68.14745% <100.00000%> (+0.28015%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh enabled auto-merge (squash) October 28, 2025 23:32
@j0sh j0sh merged commit b73f3ec into master Oct 30, 2025
17 of 18 checks passed
@j0sh j0sh deleted the ja/remoteaddr-ipv6 branch October 30, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants