Skip to content

Fix OUTPUT environment variable for LKL build. #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thehajime merged 1 commit into from
Mar 31, 2025
Merged

Fix OUTPUT environment variable for LKL build. #586

thehajime merged 1 commit into from
Mar 31, 2025

Conversation

@rodionov
Copy link

@rodionov rodionov commented Mar 30, 2025

This enables building LKL outside of source tree.

mkdir /tmp/lkl_out
OUTPUT=/tmp/lkl_out make -C tools/lkl -j32

@rodionov rodionov requested review from tavip and thehajime March 30, 2025 04:43
@rodionov rodionov changed the title Fix OUTPUT environment variable for LKL build and add arch memmove implementation. Fix OUTPUT environment variable for LKL build. Mar 30, 2025
@rodionov
Fix OUTPUT environment variable for LKL build.
eca6448 
This enables building LKL outside of source tree.

```
mkdir /tmp/lkl_out
OUTPUT=/tmp/lkl_out make -C tools/lkl -j32
```

Signed-off-by: Eugene Rodionov <[email protected]>
@rodionov rodionov linked an issue Mar 30, 2025 that may be closed by this pull request
LKL build doesn't work with OUTPUT variable other than the source tree #581
Closed
@thehajime
Copy link
Member

thehajime commented Mar 31, 2025

thanks @rodionov for the patch.

I was wondering if we can use O= variable to the command line instead of OUTPUT=, which is the standard way of kbuild to specify the output directory, and I thought LKL also follows this way.

wish to ask @tavip for the initial design.

tavip
tavip approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@tavip tavip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like OUTPUT was introduced a long time ago in 9bf4b14. I am OK leaving as it is for this fix, we could rename it to O in a subsequent PR.

@thehajime
Copy link
Member

thehajime commented Mar 31, 2025

It looks like OUTPUT was introduced a long time ago in 9bf4b14.

Oooh, yes, that was me...

without this patch, make -C tools/lkl O=somewhere (not OUTPUT=) failed and with this patch the issue fixes.
I think we can merge this.

@thehajime thehajime merged commit 11f5b7e into lkl:master Mar 31, 2025
13 of 14 checks passed
@thehajime
Copy link
Member

thehajime commented Mar 31, 2025

thanks @rodionov @tavip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavip tavip tavip approved these changes

@thehajime thehajime Awaiting requested review from thehajime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LKL build doesn't work with OUTPUT variable other than the source tree

3 participants

@rodionov @thehajime @tavip