fix s390x big endian builds #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s390x detection is broken in that filters for "elf64-s390" using the '-' trimmed EXEC_FMT variable. Additionally, set_kernel_config_h is called with LKL_CONFIG_ENDIAN, which doesn't match LKL_CONFIG_BIG_ENDIAN checked for in byteorder.h. Change this to LKL_CONFIG_CPU_BIG_ENDIAN in preparation for removing the redundant CONFIG_BIG_ENDIAN setting. Fixes: 0d680a3 ("lkl: remove CONFIG_ leaks in uapi headers") Signed-off-by: David Disseldorp <[email protected]>
In contrast to CONFIG_CPU_BIG_ENDIAN, CONFIG_BIG_ENDIAN isn't used outside of arch/lkl. Remove it. Signed-off-by: David Disseldorp <[email protected]>
LKL's final kernel config is created by appending the tools/lkl/Makefile.autoconf generated kernel.config to .config and then calling "make ARCH=lkl olddefconfig". With the existing config CPU_BIG_ENDIAN setting of "def_bool n", a .config with CONFIG_CPU_BIG_ENDIAN=y appended will drop the CONFIG_CPU_BIG_ENDIAN=y setting when "make ARCH=lkl olddefconfig" is called. This issue is resolved by changing config CPU_BIG_ENDIAN to: bool "Big-endian kernel" default n Signed-off-by: David Disseldorp <[email protected]>
arch/lkl/include/generated/uapi/asm/config.h is generated at build time with any of: #define LKL_CONFIG_64BIT 1 #define LKL_CONFIG_CPU_BIG_ENDIAN 1 based on the build environment. Generation is handled by Makefiles under tools/lkl, where it is then copied to arch/lkl/include/generated/uapi/asm/config.h prior to kernel compilation. This change simplifies header generation by doing it directly in the arch/lkl parent Makefile. It also improves rebuild times by only rewriting config.h if its contents would change. Signed-off-by: David Disseldorp <[email protected]>
Author
Hmm, my config.h generator changes rely on I've pushed a v2 which uses printf instead. |
Author
|
The checkpatch warning can IMO be ignored: I.e. 13 sha1 chars are used instead of 12 chars. |
tavip
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tracked in #594 , there are currently a few bugs which break s390x builds:
These changes attempt to fix the above issues. The last commit as a cleanup.
https://build.opensuse.org/public/build/home:ddiss:lkl_s390x/openSUSE_Factory_zSystems/s390x/lkl/_log is a successful s390x build log with these patches applied (atop a 6.4 based LKL kernel).