feat: add fips-compliant annotation to CSV #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Edgar <[email protected]>
rhdedgar
requested review from
VaishnaviHire,
cdoern,
derekhiggins,
leseb,
mfleader,
nathan-weinberg and
rhuss
as code owners
|
This appears to be openshift specific, I wonder if it should only be in midstream only, although we already have openshift annotations in here so maybe its ok? |
|
Hi, I'm ok either way, it should be a no-op for most purposes upstream. Though the |
|
Maybe we just add this in overlays for midstream, since the csv is not part of deployment by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
features.operators.openshift.io/fips-compliant: "true"annotation to the CSV as per the FIPS Operator checklist.Closes RHAIENG-1325.