-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Implement keyword search
and delete_chunk
at ChromaDB
#3057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
keyword search
and delete_chunk
at ChromaDBkeyword search
and delete_chunk
at ChromaDB
@franciscojavierarceo If you have time, Can you review my PR? 😀 |
@r3v5 Hi, Thanks for your review! I want to check something. We have both vector and keyword search method for ChromaDB. |
Yes |
@r3v5 Thank you for your quick reply. I implement hybrid search. |
Hi @bwook00! Nice work. One suggestion, don't add explicitly |
The name of the class |
Okay! I'm going to wait for #3064 merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your PR to exclude llama_stack/providers/utils/vector_io/vector_utils.py from your PR. Rebase from main since #3064 was merged
What does this PR do?
Keyword Search
keyword search is based on chroma cookbook
Delete Chunk
I added delete chunk function
Hybrid Search
Hybrid Search is not yet officially supported by Chroma chroma issue
This issue is related #3008 but I don't know this is end of issue
So, If I have to do something more, feel free to comment!
close #3008
Test Plan
I add test code and run by below command