Skip to content

chore: Added default string to HuggingfacePostTrainingConfig #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cheesecake100201 wants to merge 9 commits into from
Closed

chore: Added default string to HuggingfacePostTrainingConfig #3109

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db6693e
chore: Added default string to HuggingfacePostTrainingConfig
Aug 12, 2025
7713142
chore:Updated empty string to None
Aug 12, 2025
8768432
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
cheesecake100201 Aug 12, 2025
6520a6d
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
Aug 14, 2025
5ce2f00
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
cheesecake100201 Aug 19, 2025
75bdc7b
chore:Added a check for if dpo_output_dir exists in config
Aug 19, 2025
d0d7376
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
cheesecake100201 Aug 25, 2025
0390054
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
cheesecake100201 Aug 26, 2025
66f4af7
Merge branch 'main' into HuggingfacePostTrainingConfig-branch
cheesecake100201 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llama_stack/providers/inline/post_training/huggingface/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class HuggingFacePostTrainingConfig(BaseModel):
dpo_beta: float = 0.1
use_reference_model: bool = True
dpo_loss_type: Literal["sigmoid", "hinge", "ipo", "kto_pair"] = "sigmoid"
dpo_output_dir: str
dpo_output_dir: str = ""
Copy link
Collaborator

@cdoern cdoern Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dpo_output_dir: str = ""
dpo_output_dir: str | None = None

I think None is a more suitable default rather than an empty string, some checks for None would be great too in the code, thanks!

Copy link
Contributor Author

@cheesecake100201 cheesecake100201 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense will make the same change


@classmethod
def sample_run_config(cls, __distro_dir__: str, **kwargs: Any) -> dict[str, Any]:
Expand Down
Loading