chore: enable mypy type checking for llama_guard safety provider
#3250
Conversation
Elbehery
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
Elbehery
changed the title
mypy type checking for llama_guard safety provider
Elbehery
force-pushed
the
20250825_add_mypy_llama_guard
branch
6 times, most recently
from
8455e1d to
27c2eb2
Compare
Signed-off-by: Mustafa Elbehery <[email protected]>
Elbehery
force-pushed
the
20250825_add_mypy_llama_guard
branch
from
27c2eb2 to
0543f74
Compare
|
@Elbehery any tooling used to generate these changes? can you declare ? |
hello ✋🏽 i remove the file from then i use |
| @@ -271,7 +275,7 @@ def get_safety_categories(self) -> list[str]: | |||
|
|
|||
| return final_categories | |||
|
|
|||
| def validate_messages(self, messages: list[Message]) -> None: | |||
| def validate_messages(self, messages: list[Message]) -> list[Message]: | |||
There was a problem hiding this comment.
not sure why this was named validate_messages in the first place, seems this function is altering the messages and returning messages, can we rename this to process_messages?
| @@ -136,6 +136,8 @@ | |||
|
|
|||
|
|
|||
| class LlamaGuardSafetyImpl(Safety, ShieldsProtocolPrivate): | |||
| shield_store: ShieldStore | |||
There was a problem hiding this comment.
shield_store exists in the parent class of Safety already, do we need this here as well?
| elif isinstance(c, ImageContentItem): | ||
| if most_recent_img is None and m.role == Role.user.value: | ||
| most_recent_img = c | ||
| content.append(c) | ||
| # Note: we handle images separately for vision models |
There was a problem hiding this comment.
can we remove the comment, this function is only for text input?
| | OpenAIToolMessageParam | ||
| | OpenAIDeveloperMessageParam | ||
| ) | ||
| openai_messages = [cast(openai_message_param, openai_message)] |
There was a problem hiding this comment.
can we move the conversion logic to a different function? Also, move all the imports to top of the module?
What does this PR do?
This PR removes llama_guard from mypy exclude list and fix all type errors to enable strict type checking for the LlamaGuard safety provider implementation.
Changes:
Part of #2647
Supersedes #2676