WIP: auto instrument #3733
Draft
WIP: auto instrument #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamemilio
changed the title
meta-cla
bot
added
the
CLA Signed
iamemilio
changed the title
iamemilio
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the next step towards full auto instrumentation with OTEL. Due to some known issues with uvicorn and OTEL, this must install automatic instrumentation in the server subprocess. This ensures full coverage and gets us started with a more native telemetry solution, but does mean that servers will be deployed with telemetry enabled by default. To disable it, we will instruct users to use the following standard design pattern for open telemetry:
export OTEL_SDK_DISABLED=trueTesting
This has been manually tested using the
scripts/telemetrytools, and returns full distributed traces with dependency graphing.