fix: replace python-jose with PyJWT for JWT handling #3756
Merged
+93
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
Opening as a draft because I want to do proper testing. |
leseb
changed the title
leseb
force-pushed
the
rm-python-jose-dep
branch
from
29f2772 to
97b409e
Compare
|
From the python-jose docs, it looks like you could switch to |
|
I guess I'm wrong, |
|
I did some testing, and even through |
leseb
force-pushed
the
rm-python-jose-dep
branch
3 times, most recently
from
4df0466 to
1f50a02
Compare
leseb
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
ashwinb
reviewed
Oct 10, 2025
ashwinb
reviewed
Oct 10, 2025
This commit migrates the authentication system from python-jose to PyJWT to eliminate the dependency on the archived rsa package. The migration includes: - Refactored OAuth2TokenAuthProvider to use PyJWT's PyJWKClient for clean JWKS handling - Removed manual JWKS fetching, caching and key extraction logic in favor of PyJWT's built-in functionality The new implementation is cleaner, more maintainable, and follows PyJWT best practices while maintaining full backward compatibility. Signed-off-by: Sébastien Han <[email protected]>
Pass TLS certs to the PyJWKClient Signed-off-by: Sébastien Han <[email protected]>
If verify_tls is False we disable the cert verification in the ssl context. Signed-off-by: Sébastien Han <[email protected]>
Kubernetes JWT endpoint is authenticated so we must pass the token from the config in the PyJWKClient's client header to fetch the public keys. Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
rm-python-jose-dep
branch
from
1f50a02 to
657052b
Compare
Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
rm-python-jose-dep
branch
from
657052b to
c314275
Compare
franciscojavierarceo
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit migrates the authentication system from python-jose to PyJWT to eliminate the dependency on the archived rsa package. The migration includes:
The new implementation is cleaner, more maintainable, and follows PyJWT best practices while maintaining full backward compatibility.
Test Plan
Unit tests. Auth CI.