fix: 3769 graceful provider registration failure

[akram]

What does this PR do?

fixes #3769

Test Plan

have a config-registered-models.yaml run

version: 2
image_name: config-registered-models
apis:
- inference
providers:
  inference:
  - provider_id: openai
    provider_type: remote::openai
    config:
      api_key: BOGUS
metadata_store:
  type: sqlite
  db_path: /tmp/config-registered-model.db
models:
- model_id: test-model
  provider_id: openai
  provider_model_id: custom-model
  model_type: llm

and run

llama stack run config-registered-models.yaml

server is not crashing anymore

INFO     2025-10-10 23:54:35,214 uvicorn.error:84 uncategorized: Started server process [51980]
INFO     2025-10-10 23:54:35,215 uvicorn.error:48 uncategorized: Waiting for application startup.
INFO     2025-10-10 23:54:35,215 llama_stack.core.server.server:177 core::server: Starting up
INFO     2025-10-10 23:54:35,216 llama_stack.core.stack:421 core: starting registry refresh task
INFO     2025-10-10 23:54:35,221 uvicorn.error:62 uncategorized: Application startup complete.
INFO     2025-10-10 23:54:35,222 uvicorn.error:216 uncategorized: Uvicorn running on http://['::', '0.0.0.0']:8321
         (Press CTRL+C to quit)
ERROR    2025-10-10 23:54:35,379 llama_stack.providers.utils.inference.openai_mixin:434 providers::utils:
         OpenAIInferenceAdapter.list_provider_model_ids() failed with: Error code: 401 - {'error': {'message':
         'Incorrect API key provided: BOGUS. You can find your API key at
         https://platform.openai.com/account/api-keys.', 'type': 'invalid_request_error', 'param': None, 'code':
         'invalid_api_key'}}

cc @mattf

[akram]

/assign @mattf
/assign @ashwinb

[ashwinb]

we should absolutely not do this. this means bogus things in run.yaml will continue to not get fixed. it is not an acceptable method to hide errors like this.

[akram]

Hi @ashwinb , thanks for the review.
The error is still logged with an ERROR level as shown in the PR's comment. So, the error is not hidden per se. Or maybe I get it wrong ?

[akram]

/hold

[ashwinb]

Hi @ashwinb , thanks for the review. The error is still logged with an ERROR level as shown in the PR's comment. So, the error is not hidden per se. Or maybe I get it wrong ?

Yes. We cannot catch the exception, the server should be dying if you misconfigure it like that.