-
Couldn't load subscription status.
- Fork 35
Tekton Orchestrated Benchmarking POC #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kalantar
wants to merge
46
commits into
llm-d:main
Choose a base branch
from
kalantar:tekton-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
4644ab6
values files
kalantar 40bf8cd
update gateway
kalantar 9041ccc
change model label
kalantar 698d774
harness launcher chart
kalantar 0516f2b
model-download chart
kalantar ae36f88
try without backslash
kalantar aeec000
try without backslash
kalantar 90473a5
restructure args
kalantar b68c2f7
hack
kalantar 37893a1
hack
kalantar f9e1372
extend hack
kalantar 91c6c2f
more image configurability
kalantar cde1549
quote
kalantar 9792fa5
MODELID
kalantar 24c8fe1
inital pipeline
kalantar 5c66007
inital pipeline
kalantar abc0419
utility to manage parallelism
kalantar 46d469f
change workload steps
kalantar 59b329a
update readme
kalantar 8dfadd8
pin image version
kalantar ed015a8
update roles.yaml
kalantar 0fb4271
update readme
kalantar 6535c56
update readme
kalantar d349a01
remove hardcoded param
kalantar 28fabf1
expose s3 config
kalantar ec1a648
document s3
kalantar 34c4181
Merge branch 'main' into tekton-poc
kalantar f6c062b
clarify use of namespace
kalantar afb5655
change image for s3 upload
kalantar 78de7de
prevent using kalantar ns
kalantar 17bee4b
prevent using kalantar ns
kalantar f918279
delete experiment namespaces
kalantar c5a5e38
pd yaml
kalantar 5f4e42b
update secret name
kalantar c3754c7
update fullnameoverride
kalantar 3fcbb20
fix tensor
kalantar b09aa28
gateway name
kalantar b60f447
desitation name
kalantar a3407ae
label
kalantar 2af0868
progress towards pd scenario
kalantar e730192
remove --tensor-parallel-size
kalantar 8f29639
Merge branch 'main' into tekton-poc
kalantar 3bacf14
capacity planner
kalantar 2f33417
Merge branch 'main' into tekton-poc
kalantar 62fc6c4
reduce task pod requirements
kalantar 218833f
rename a few things
kalantar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Patterns to ignore when building packages. | ||
| # This supports shell glob matching, relative path matching, and | ||
| # negation (prefixed with !). Only one pattern per line. | ||
| .DS_Store | ||
| # Common VCS dirs | ||
| .git/ | ||
| .gitignore | ||
| .bzr/ | ||
| .bzrignore | ||
| .hg/ | ||
| .hgignore | ||
| .svn/ | ||
| # Common backup files | ||
| *.swp | ||
| *.bak | ||
| *.tmp | ||
| *.orig | ||
| *~ | ||
| # Various IDEs | ||
| .project | ||
| .idea/ | ||
| *.tmproj | ||
| .vscode/ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| apiVersion: v2 | ||
| name: llm-d-benchark | ||
| description: A Helm chart for the experiment harness in llm-d-benchmark | ||
|
|
||
| # A chart can be either an 'application' or a 'library' chart. | ||
| # | ||
| # Application charts are a collection of templates that can be packaged into versioned archives | ||
| # to be deployed. | ||
| # | ||
| # Library charts provide useful utilities or functions for the chart developer. They're included as | ||
| # a dependency of application charts to inject those utilities and functions into the rendering | ||
| # pipeline. Library charts do not define any templates and therefore cannot be deployed. | ||
| type: application | ||
|
|
||
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: "v0.0.1" | ||
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "v0.3.0" | ||
|
|
||
| maintainers: | ||
| - name: "Michael Kalantar" | ||
| email: "[email protected]" | ||
| url: "https://github.com/kalantar" | ||
|
|
||
| sources: | ||
| - https://github.com/llm-d/llm-d-benchmark | ||
|
|
||
| # dependencies: | ||
| # - name: common | ||
| # repository: https://charts.bitnami.com/bitnami | ||
| # tags: | ||
| # - bitnami-common | ||
| # version: "2.27.0" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "harness.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
|
|
||
| {{/* | ||
| Create chart name and version as used by the chart label. | ||
| Truncated to 63 characrters because Kubernetes label values are limited to this | ||
| */}} | ||
| {{- define "harness.chart" -}} | ||
| {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create common labels for the resources managed by this chart. | ||
| */}} | ||
| {{- define "harness.labels" -}} | ||
| helm.sh/chart: {{ include "harness.chart" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{- define "harness.sanitizeString" -}} | ||
| {{- $input := . | lower | replace "." "-" | replace "/" "-" -}} | ||
| {{- $input -}} | ||
| {{- end -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: {{ .Values.harness.type }}-launcher | ||
| labels: | ||
| app: {{ .Values.harness.type }}-launcher | ||
| spec: | ||
| serviceAccountName: {{ include "harness.name" . }}-runner | ||
| containers: | ||
| - name: harness | ||
| image: "{{ .Values.harness.image.registry }}/{{ .Values.harness.image.repository }}/{{ .Values.harness.image.name }}:{{ .Values.harness.image.tag }}" | ||
| imagePullPolicy: {{ .Values.harness.image.pullPolicy }} | ||
| securityContext: | ||
| runAsUser: 0 | ||
| command: ["sh", "-c"] | ||
| args: | ||
| {{- toYaml .Values.harness.args | nindent 4 }} | ||
| env: | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_LAUNCHER | ||
| value: "1" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_ANALYZE_LOCALLY | ||
| value: "0" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_HARNESS | ||
| value: "{{ .Values.harness.type }}-llm-d-benchmark.sh" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_ANALYZER | ||
| value: "{{ .Values.harness.type }}-analyze_results.sh" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_HARNESS_WORKLOAD_NAME | ||
| value: "{{ .Values.experiment.profile.name }}" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_ID | ||
| value: "{{ .Values.experiment.identifier }}" | ||
| - name: LLMDBENCH_HARNESS_NAME | ||
| value: "{{ .Values.harness.type }}" | ||
| - name: LLMDBENCH_RUN_EXPERIMENT_RESULTS_DIR | ||
| value: "/requests/{{ .Values.harness.type }}_{{ .Values.experiment.identifier }}_{{ .Values.stack.name }}" | ||
| - name: LLMDBENCH_CONTROL_WORK_DIR | ||
| value: "/requests/{{ .Values.harness.type }}_{{ .Values.experiment.identifier }}_{{ .Values.stack.name }}" | ||
| - name: LLMDBENCH_HARNESS_NAMESPACE | ||
| value: "{{ .Release.Namespace }}" | ||
| - name: LLMDBENCH_HARNESS_STACK_TYPE | ||
| value: "{{ .Values.stack.type }}" | ||
| - name: LLMDBENCH_HARNESS_STACK_ENDPOINT_URL | ||
| value: "{{ .Values.stack.endpointUrl }}" | ||
| - name: LLMDBENCH_HARNESS_STACK_NAME | ||
| value: {{ include "harness.sanitizeString" .Values.stack.model | quote }} | ||
| - name: LLMDBENCH_DEPLOY_METHODS | ||
| value: "{{ .Values.stack.deployMethod }}" | ||
| - name: LLMDBENCH_MAGIC_ENVAR | ||
| value: "harness_pod" | ||
|
|
||
| - name: LLMDBENCH_LLMD_IMAGE_REGISTRY | ||
| value: {{ .Values.harness.image.registry }} | ||
| - name: LLMDBENCH_LLMD_IMAGE_REPO | ||
| value: {{ .Values.harness.image.repository }} | ||
| - name: LLMDBENCH_LLMD_IMAGE_NAME | ||
| value: {{ .Values.harness.image.name }} | ||
| - name: LLMDBENCH_LLMD_IMAGE_TAG | ||
| value: {{ .Values.harness.image.tag | quote }} | ||
| {{- with .Values.harness.extraEnv }} | ||
| - name: {{ .name }} | ||
| value: "{{ .value }}" | ||
| {{- end }} | ||
|
|
||
| # TBD add_env_vars_to_pod $LLMDBENCH_CONTROL_ENV_VAR_LIST_TO_POD | ||
| - name: LLMDBENCH_DEPLOY_CURRENT_MODEL | ||
| value: "{{ .Values.stack.model }}" | ||
| - name: LLMDBENCH_DEPLOY_CURRENT_MODELID | ||
| value: {{ include "harness.sanitizeString" .Values.stack.model | quote }} | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_PREFILL_REPLICAS | ||
| value: "0" | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_DECODE_REPLICAS | ||
| value: "2" | ||
| - name: LLMDBENCH_VLLM_COMMON_AFFINITY | ||
| value: "nvidia.com/gpu.product:NVIDIA-H100-80GB-HBM3" | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_DECODE_TENSOR_PARALLELISM | ||
| value: "4" | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_DECODE_DATA_PARALLELISM | ||
| value: "1" | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_PREFILL_TENSOR_PARALLELISM | ||
| value: "1" | ||
| - name: LLMDBENCH_VLLM_MODELSERVICE_PREFILL_DATA_PARALLELISM | ||
| value: "1" | ||
|
|
||
| - name: HF_TOKEN_SECRET | ||
| value: "hf-secret" | ||
| - name: HUGGING_FACE_HUB_TOKEN | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: hf-secret | ||
| key: HF_TOKEN | ||
| resources: | ||
| {{- toYaml .Values.harness.resources | nindent 6 }} | ||
| volumeMounts: | ||
| - name: results | ||
| mountPath: /requests | ||
| - name: {{ .Values.harness.type }}-profiles | ||
| mountPath: /workspace/profiles/{{ .Values.harness.type }} | ||
| volumes: | ||
| - name: results | ||
| persistentVolumeClaim: | ||
| claimName: {{ .Values.harness.resultsPVC }} | ||
| - name: {{ .Values.harness.type }}-profiles | ||
| configMap: | ||
| name: {{ .Values.harness.type }}-profiles | ||
| restartPolicy: Never |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: {{ include "harness.name" . }}-job-creator | ||
| labels: | ||
| {{- include "harness.labels" . | nindent 4 }} | ||
| rules: | ||
| - apiGroups: ["batch"] | ||
| resources: ["jobs"] | ||
| verbs: ["create", "get", "list", "watch", "delete", "patch", "update"] | ||
| - apiGroups: [""] | ||
| resources: ["serviceaccounts"] | ||
| verbs: ["get"] | ||
| - apiGroups: [""] | ||
| resources: ["pods"] | ||
| verbs: ["get", "list", "watch"] | ||
| - apiGroups: [""] | ||
| resources: ["pods/log"] | ||
| verbs: ["get"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: {{ include "harness.name" . }}-job-creator-binding | ||
| labels: | ||
| {{- include "harness.labels" . | nindent 4 }} | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: {{ include "harness.name" . }}-runner | ||
| roleRef: | ||
| kind: Role | ||
| name: {{ include "harness.name" . }}-job-creator | ||
| apiGroup: rbac.authorization.k8s.io | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: {{ include "harness.name" . }}-restricted-scc | ||
| labels: | ||
| {{- include "harness.labels" . | nindent 4 }} | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: {{ include "harness.name" . }}-runner | ||
| roleRef: | ||
| kind: ClusterRole | ||
| name: system:openshift:scc:restricted | ||
| apiGroup: rbac.authorization.k8s.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: {{ include "harness.name" . }}-runner | ||
| labels: | ||
| {{- include "harness.labels" . | nindent 4 }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this chart needed?
Can we simply use the inference-perf container as part of the StepAction, and configure it so that the step actually directly sends the Inference request?
This approach eliminates the chart, along with the need for a separate harness pod (the Tekton step will run as part of some pod anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step has now been updated to use the llm-d-benchmark image directly. It isn't as clean as it might be to use the inference-perf image directly. However, it should also be possible to modify it to be easier to use.