Decompose hex to 18 tets for clipping #1753
Merged
+243
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For backward compatibility and on-going evaluation of using 18 tets, the 24-tet decomposition is still supported. The choice is in the compile-time parameter NUM_TETS_PER_HEX.
gunney1
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
jcs15c,
kennyweiss and
rhornung67
gunney1
added
Quest
Arlie-Capps
reviewed
Jan 5, 2026
Arlie-Capps
approved these changes
Jan 5, 2026
Contributor
Arlie-Capps
left a comment
Arlie-Capps
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @gunney1 .
bmhan12
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 18-tet decomposition should reduce work compared to the default 24-tet decomposition, because it generates fewer tets. If a hex face has 4 coplanar vertices, there will be degenerate tets, so we check for them. For on-going performance evaluation, we are supporting both decompositions for now.
This change is part of the bigger change for improving mesh clipping performance.