Remove fn body pass #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Some initial comments.
| add_library(RemoveFunctionBody SHARED RemoveFunctionBody.cpp) | ||
| target_link_libraries(RemoveFunctionBody "$<$<PLATFORM_ID:Darwin>:-undefined dynamic_lookup>") | ||
|
|
||
| # separate_arguments(LLVM_DEFINITIONS_LIST NATIVE_COMMAND ${LLVM_DEFINITIONS}) |
Contributor
There was a problem hiding this comment.
The commented sections can probably go away?
|
|
||
| project(RemoveFunctionBodyPass) | ||
|
|
||
| set(LT_LLVM_INSTALL_DIR "" CACHE PATH "LLVM installation directory") |
Contributor
There was a problem hiding this comment.
Why do we need to set this path? Doesn't opt support explicitly passing the shard object path?
| #include "llvm/Passes/PassPlugin.h" | ||
| #include "llvm/Support/CommandLine.h" | ||
| using namespace llvm; | ||
| using namespace std; |
Contributor
There was a problem hiding this comment.
Please to not use using namespace std.
|
|
||
| namespace { | ||
| cl::list<int> Lists("index", cl::desc("Specify function index"), cl::OneOrMore); | ||
| struct RemoveFunctionBodyPass : PassInfoMixin<RemoveFunctionBodyPass> { |
Contributor
There was a problem hiding this comment.
Why is this a struct and not a class?
| @@ -0,0 +1,3 @@ | |||
| mkdir build && cd build | |||
| cmake -GNinja .. | |||
Contributor
There was a problem hiding this comment.
This script doesn't seem to be particularly useful and I don't think it needs to be in-tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module load ninjato loadninjabuild package. Go into RemoveFunctionBodyPass directory (cd llvm-ir-dataset-utils-internal/llvm_ir_dataset_utils/tools/RemoveFunctionBodyPass), run./installto build and install the out-of-tree pass.opt -load build/libRemoveFunctionBody.so -load-pass-plugin=build/libRemoveFunctionBody.so -passes='remove-fn-body' -index <index in integer here> <path to bitcode module file>(insideRemoveFunctionBodyPassdirectory. If want to try somewhere else, modify the path after-loadand-load-pass-plugin)