Adding python files for graphing and processing csv data. #38
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
It doesn't seem like there's any script here to invoke this from the command line to actually run it? How do you envision this being used? Inside a Jupyter notebook?
If this is planned on being used through a CLI script, at least a simple one should probably land within this patch.
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/read_column.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/read_column.py
Outdated
Show resolved
Hide resolved
…ial jupyter notebook file to display results.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Mostly LGTM, one final comment.
Also, please take a look at the failing CI jobs.
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
…ysis process in read_column.py.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Might be useful to read the Google Python style guide to see how good docstrings are written: https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings.
There are some reasonable examples in https://github.com/google/ml-compiler-opt/tree/main/compiler_opt/benchmark if you look through the individual python files.
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/fitting_and_plotting.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/read_column.py
Outdated
Show resolved
Hide resolved
llvm_ir_dataset_utils/compile_time_analysis_tools/python_processing/read_column.py
Outdated
Show resolved
Hide resolved
…vm-ir-dataset-utils into py_process_tools
… output to have only the outliers data.
2 participants
No description provided.