[CIR] Refactor AddressSpace to use enum more thoroughly instead of attribute #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xlauko
commented
Jul 4, 2025
xlauko
commented
- Remove redundant custom printer and parser for AddressSpace, relying instead on MLIR's default EnumAttr handling.
- Leverage AddressSpace::Default to omit the attribute from the assembly form when not needed. Therefore, an empty attribute is no longer needed to represent the default address space.
- Update PointerType to use the AddressSpace enum directly, instead of a boxed attribute.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…tribute - Remove redundant custom printer and parser for AddressSpace, relying instead on MLIR's default EnumAttr handling. - Leverage AddressSpace::Default to omit the attribute from the assembly form when not needed. Therefore, an empty attribute is no longer needed to represent the default address space. - Update PointerType to use the AddressSpace enum directly, instead of a boxed attribute.
xlauko
force-pushed
the
users/xlauko/cir-addrspace-attr
branch
from
6198709 to
a695d3e
Compare
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 15, 2025
…rest of attributes This mirrors incubator change from llvm/clangir#1733
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 15, 2025
…rest of attributes This mirrors incubator change from llvm/clangir#1733
xlauko
added a commit
to llvm/llvm-project
that referenced
this pull request
Jul 15, 2025
…rest of attributes (#148850) This change allows enum definition classes to be included in type definitions without creating cyclic dependencies between CIRTypes.td and CIRAttrs.td, since attributes already include CIRTypes.td. In the pull request mentioned below, this is used to define the AddressSpace enum alongside PointerType. Additionally, this introduces `DefaultValuedEnumParameter`. This mirrors some parts of incubator change from llvm/clangir#1733
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 15, 2025
…ithout the rest of attributes (#148850) This change allows enum definition classes to be included in type definitions without creating cyclic dependencies between CIRTypes.td and CIRAttrs.td, since attributes already include CIRTypes.td. In the pull request mentioned below, this is used to define the AddressSpace enum alongside PointerType. Additionally, this introduces `DefaultValuedEnumParameter`. This mirrors some parts of incubator change from llvm/clangir#1733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.