[CIR] Fix parsing of a generic TBAAAttr #1846
Conversation
Jezurko
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Jezurko
force-pushed
the
tbaa-parse-error
branch
from
5833486 to
f246e76
Compare
I'm not sure I do, maybe @xlauko knows some tricks |
|
We've had a side-channel discussion with @xlauko and I reworked the solution. |
| @@ -14,6 +14,7 @@ | |||
| #define CLANG_CIR_DIALECT_IR_CIRTBAAATTRS_TD | |||
|
|
|||
| include "clang/CIR/Dialect/IR/CIRTypes.td" | |||
| include "clang/CIR/Dialect/IR/CIRAttrs.td" | |||
There was a problem hiding this comment.
This is cyclic dependency CIRAttrs.td include CIRTBAAAttrs.td
There was a problem hiding this comment.
Hm, I guess I will have to move CIR_Attr to a different file then. I need this include to be able to generate the hpp/cpp for the constraint from CIR_AnyTBAAAttr
| def CIR_TBAAAttrConstraint : AttrConstraint<CPred<"::cir::isTBAAAttr($_self)">>{ | ||
| string cppType = "::mlir::Attribute"; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is literally the same as CIR_AnyTBAAAttr. Why don't you use that everywhere?
There was a problem hiding this comment.
Because the constraint is used in the definition of the TBAA Attributes and I can't define the CIR_AnyTBAAAttr before the attributes are defined
This PR fixes an issue when parsing
TBAAAttrderived attributes.The root cause of the issue is that the RTTI system is not capable of downcasting
mlir::Attributeto theBaseType, which iscir::TBAAAttr, since each attribute has its unique TypeID. As such, the default generated parser fails, because thedyn_casttocir::TBAAAttrfails (this happens for example with the attached test case).If anyone can think of a solution that wouldn't require explicitly listing all the attributes I'm happy to modify it.