[CIR] Streamline unit attribute setters using pre-generated ones #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlauko
requested review from
lanza,
bcardosolopes and
andykaylor
as code owners
tommymcm
reviewed
Aug 22, 2025
| @@ -252,7 +248,7 @@ CIRGenFunction::emitCoroutineBody(const CoroutineBodyStmt &S) { | |||
|
|
|||
| auto Fn = dyn_cast<cir::FuncOp>(CurFn); | |||
| assert(Fn && "other callables NYI"); | |||
| Fn.setCoroutineAttr(mlir::UnitAttr::get(&getMLIRContext())); | |||
| Fn.setCoroutine(true); | |||
There was a problem hiding this comment.
Separate concern: should we rename these optional attributes to follow some pattern? Right now we have both thing and is_thing, for example load has is_deref while function has coroutine. After these changes (which are great) it gets a bit more confusing as to what's happening in these setters/getters.
There was a problem hiding this comment.
I would be for is_thing when it makes sense. But things like no_signed_wrap sound weird as is_no_signed_wrap.
There was a problem hiding this comment.
That's true. We can do a case by case thing and this isn't high priority.
bcardosolopes
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.