[CIR] Add IITDescriptor type cases #1852
Merged
+59
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhsundar
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
|
First patch related to #1820 |
anirudhsundar
force-pushed
the
cir_add_iitdesc_types
branch
from
c704401 to
d2e614d
Compare
anirudhsundar
force-pushed
the
cir_add_iitdesc_types
branch
from
d2e614d to
445c6a9
Compare
bcardosolopes
requested changes
Aug 22, 2025
There was a problem hiding this comment.
Thanks for your first contribution, way to go! We need some tests that can exercise the newly added handling for the types!
If that would requiring adding more support for instructions, than probably just keep this PR for all NYI and you can incrementally introduce the types in different PRs as you can write testcases for those.
This patch adds support for IITDescriptor::Vector type and adds NYI for the others.
anirudhsundar
force-pushed
the
cir_add_iitdesc_types
branch
from
445c6a9 to
7ae3353
Compare
anirudhsundar
changed the title
bcardosolopes
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for IITDescriptor::Vector type and adds
NYI for the others.