[CIR][MLIR][LoweringThroughMLIR] CIRUnaryOpLowering on float values. #2032
+73
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terapines-osc-cir
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
UnaryOpKind Inc, Dec, Plus and Minus can accept float operands, the lowering should also handle those situations.
terapines-osc-cir
force-pushed
the
cir-to-mlir-unary-op-fix
branch
from
e8517f6 to
f3e89e6
Compare
| auto One = mlir::arith::ConstantOp::create( | ||
| rewriter, op.getLoc(), mlir::IntegerAttr::get(type, 1)); | ||
| rewriter.replaceOpWithNewOp<mlir::arith::SubIOp>(op, type, input, One); | ||
| addImmediate(op, type, input, -1, rewriter); |
Contributor
There was a problem hiding this comment.
while this is correct, should this emit mlir::arith::SubIOp/mlir::arith::SubFOp instead, since that was the case previously?
| return rewriter.replaceOpWithNewOp<mlir::arith::AddFOp>(op, type, input, | ||
| imm); | ||
| } | ||
| auto imm = mlir::arith::ConstantOp::create(rewriter, op.getLoc(), |
Contributor
There was a problem hiding this comment.
should we add an assertion that checks if type is an IntegerType before this? not sure if it's a possible case though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnaryOpKind Inc, Dec, Plus and Minus can accept float operands, the lowering should also handle those situations.
Before this commit, the compiler crash when it met float operands.