Skip to content

Conversation

@xlauko
Copy link
Collaborator

@xlauko xlauko commented Nov 28, 2025

No description provided.

@xlauko
Copy link
Collaborator Author

xlauko commented Nov 28, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@xlauko xlauko marked this pull request as ready for review November 28, 2025 08:06
@xlauko xlauko marked this pull request as draft November 28, 2025 08:06
@github-actions
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/CIR/CodeGen/CIRGenModule.cpp clang/lib/CIR/Dialect/IR/CIRDialect.cpp clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVMIR.cpp clang/test/CIR/CodeGen/call-extra-attrs.cpp clang/test/CIR/CodeGen/conditional-cleanup.cpp clang/test/CIR/CodeGen/optnone.cpp --diff_from_common_commit

⚠️
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing origin/main to the base branch/commit you want to compare against.
⚠️

View the diff from clang-format here.
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 0798c5c74..e9e18e56a 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -2947,14 +2947,26 @@ void cir::FuncOp::print(OpAsmPrinter &p) {
   function_interface_impl::printFunctionAttributes(
       p, *this,
       // These are all omitted since they are custom printed already.
-      {getAliaseeAttrName(), getBuiltinAttrName(), getCoroutineAttrName(),
-       getDsoLocalAttrName(), getExtraAttrsAttrName(),
-       getFunctionTypeAttrName(), getGlobalCtorPriorityAttrName(),
-       getGlobalDtorPriorityAttrName(), getLambdaAttrName(),
-       getLinkageAttrName(), getCallingConvAttrName(), getNoProtoAttrName(),
-       getOptNoneAttrName(), getSymVisibilityAttrName(), getArgAttrsAttrName(),
-       getResAttrsAttrName(), getComdatAttrName(), getGlobalVisibilityAttrName(),
-       getAnnotationsAttrName(), getCxxSpecialMemberAttrName()});
+      {getAliaseeAttrName(),
+       getBuiltinAttrName(),
+       getCoroutineAttrName(),
+       getDsoLocalAttrName(),
+       getExtraAttrsAttrName(),
+       getFunctionTypeAttrName(),
+       getGlobalCtorPriorityAttrName(),
+       getGlobalDtorPriorityAttrName(),
+       getLambdaAttrName(),
+       getLinkageAttrName(),
+       getCallingConvAttrName(),
+       getNoProtoAttrName(),
+       getOptNoneAttrName(),
+       getSymVisibilityAttrName(),
+       getArgAttrsAttrName(),
+       getResAttrsAttrName(),
+       getComdatAttrName(),
+       getGlobalVisibilityAttrName(),
+       getAnnotationsAttrName(),
+       getCxxSpecialMemberAttrName()});
 
   if (auto aliaseeName = getAliasee()) {
     p << " alias(";

@xlauko xlauko changed the base branch from users/xlauko/simplify-function-attribute-checks to graphite-base/2036 November 28, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants