Triple: Record default exception handling type #147225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default exception handling type is scattered across the backends in MCAsmInfo constructors. Allow this to be computed from the triple so the IR can centrally determine the set of ABI calls.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 7, 2025
arsenm
requested review from
DanielKristofKiss,
dpaoliello,
efriedma-quic,
jhuber6,
frobtech,
MaskRay and
stefanp-synopsys
jhuber6
approved these changes
Jul 7, 2025
DanielKristofKiss
approved these changes
Jul 7, 2025
|
This PR caused failures on https://lab.llvm.org/buildbot/#/builders/161/builds/6921. MCJITTests fail with commit 1121034 and pass with the commit right before it. @arsenm, can you please take a look? |
arsenm
added a commit
that referenced
this pull request
Jul 10, 2025
Fixes asserting with windows-elf triples. Should fix regression reported in #147225 (comment) I'm not sure this is a valid triple, but I'm guessing the MCJIT usage is an accident. This does change the behavior from trying to use WinEH to DwarfCFI; however the backend crashes with WinEH so I'm assuming following ELF is the more correct option.
#147875 I think fixes it |
arsenm
added a commit
that referenced
this pull request
Jul 10, 2025
Fixes asserting with windows-elf triples. Should fix regression reported in #147225 (comment) I'm not sure this is a valid triple, but I'm guessing the MCJIT usage is an accident. This does change the behavior from trying to use WinEH to DwarfCFI; however the backend crashes with WinEH so I'm assuming following ELF is the more correct option.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 10, 2025
…147875) Fixes asserting with windows-elf triples. Should fix regression reported in llvm/llvm-project#147225 (comment) I'm not sure this is a valid triple, but I'm guessing the MCJIT usage is an accident. This does change the behavior from trying to use WinEH to DwarfCFI; however the backend crashes with WinEH so I'm assuming following ELF is the more correct option.
That fixed it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default exception handling type is scattered
across the backends in MCAsmInfo constructors. Allow this
to be computed from the triple so the IR can centrally determine
the set of ABI calls.