RuntimeLibcalls: Remove darwin override of half convert libcalls #148782

arsenm · 2025-07-15T06:19:35Z

These are already the default calls set for these conversions, so
they should not require explicit setting. The non-default cases are
currently overridden in ARMISelLowering. Just delete this until
the list of calls and lowering decisions are separated.

This was added back in 6402ad2. It
appears to not be relevant for AArch64, where calls appear to never
be used for these. It also appears to not be relevant for x86, where
the default calls seem to always end up used anyway.

arsenm · 2025-07-15T06:19:51Z

RuntimeLibcalls: Move __stack_chk_fail config to tablegen #148789 : 2 dependent PRs (#148792 , #150870 )
RuntimeLibcalls: Remove darwin override of half convert libcalls #148782 👈 (View in Graphite)
RuntimeLibcalls: Really move default libcall handling to tablegen #148780 : 1 other dependent PR (#150869 )
RuntimeLibcalls: Stop opting out of exp10 #148604
RuntimeLibcalls: Mostly move x86 configuration into tablegen #148575
RuntimeLibcalls: Invert handling of 64-bit only libcalls #148571
RuntimeLibcalls: Remove __muloti4 from default libcall set #148562
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

llvmbot · 2025-07-15T06:20:04Z

@llvm/pr-subscribers-backend-arm

@llvm/pr-subscribers-llvm-ir

Author: Matt Arsenault (arsenm)

Changes

These are already the default calls set for these conversions, so
they should not require explicit setting. The non-default cases are
currently overridden in ARMISelLowering. Just delete this until
the list of calls and lowering decisions are separated.

This was added back in 6402ad2. It
appears to not be relevant for AArch64, where calls appear to never
be used for these. It also appears to not be relevant for x86, where
the default calls seem to always end up used anyway.

Full diff: https://github.com/llvm/llvm-project/pull/148782.diff

1 Files Affected:

(modified) llvm/lib/IR/RuntimeLibcalls.cpp (-9)

diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index df529bc013cac..8ca31dff900cb 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -77,15 +77,6 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT,
       setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
   }
 
-  // A few names are different on particular architectures or environments.
-  if (TT.isOSDarwin()) {
-    // For f16/f32 conversions, Darwin uses the standard naming scheme,
-    // instead of the gnueabi-style __gnu_*_ieee.
-    // FIXME: What about other targets?
-    setLibcallImpl(RTLIB::FPEXT_F16_F32, RTLIB::__extendhfsf2);
-    setLibcallImpl(RTLIB::FPROUND_F32_F16, RTLIB::__truncsfhf2);
-  }
-
   if (TT.isOSOpenBSD()) {
     setLibcallImpl(RTLIB::STACKPROTECTOR_CHECK_FAIL, RTLIB::Unsupported);
   }

llvmbot · 2025-07-15T06:20:04Z

@llvm/pr-subscribers-tablegen

Author: Matt Arsenault (arsenm)

Changes

These are already the default calls set for these conversions, so
they should not require explicit setting. The non-default cases are
currently overridden in ARMISelLowering. Just delete this until
the list of calls and lowering decisions are separated.

This was added back in 6402ad2. It
appears to not be relevant for AArch64, where calls appear to never
be used for these. It also appears to not be relevant for x86, where
the default calls seem to always end up used anyway.

Full diff: https://github.com/llvm/llvm-project/pull/148782.diff

1 Files Affected:

(modified) llvm/lib/IR/RuntimeLibcalls.cpp (-9)

diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index df529bc013cac..8ca31dff900cb 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -77,15 +77,6 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT,
       setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
   }
 
-  // A few names are different on particular architectures or environments.
-  if (TT.isOSDarwin()) {
-    // For f16/f32 conversions, Darwin uses the standard naming scheme,
-    // instead of the gnueabi-style __gnu_*_ieee.
-    // FIXME: What about other targets?
-    setLibcallImpl(RTLIB::FPEXT_F16_F32, RTLIB::__extendhfsf2);
-    setLibcallImpl(RTLIB::FPROUND_F32_F16, RTLIB::__truncsfhf2);
-  }
-
   if (TT.isOSOpenBSD()) {
     setLibcallImpl(RTLIB::STACKPROTECTOR_CHECK_FAIL, RTLIB::Unsupported);
   }

llvmbot · 2025-07-15T06:20:05Z

@llvm/pr-subscribers-backend-x86

Author: Matt Arsenault (arsenm)

Changes

These are already the default calls set for these conversions, so
they should not require explicit setting. The non-default cases are
currently overridden in ARMISelLowering. Just delete this until
the list of calls and lowering decisions are separated.

This was added back in 6402ad2. It
appears to not be relevant for AArch64, where calls appear to never
be used for these. It also appears to not be relevant for x86, where
the default calls seem to always end up used anyway.

Full diff: https://github.com/llvm/llvm-project/pull/148782.diff

1 Files Affected:

(modified) llvm/lib/IR/RuntimeLibcalls.cpp (-9)

diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index df529bc013cac..8ca31dff900cb 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -77,15 +77,6 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT,
       setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume);
   }
 
-  // A few names are different on particular architectures or environments.
-  if (TT.isOSDarwin()) {
-    // For f16/f32 conversions, Darwin uses the standard naming scheme,
-    // instead of the gnueabi-style __gnu_*_ieee.
-    // FIXME: What about other targets?
-    setLibcallImpl(RTLIB::FPEXT_F16_F32, RTLIB::__extendhfsf2);
-    setLibcallImpl(RTLIB::FPROUND_F32_F16, RTLIB::__truncsfhf2);
-  }
-
   if (TT.isOSOpenBSD()) {
     setLibcallImpl(RTLIB::STACKPROTECTOR_CHECK_FAIL, RTLIB::Unsupported);
   }

tgross35

LGTM, this matches what I've seen while inspecting the tablegen output

arsenm · 2025-08-04T00:43:31Z

Merge activity

Aug 4, 12:43 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 12:51 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 1:21 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 1:30 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 1:33 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 1:50 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 1:56 AM UTC: Graphite rebased this pull request as part of a merge.
Aug 4, 2:01 AM UTC: Graphite rebased this pull request as part of a merge.

These are already the default calls set for these conversions, so they should not require explicit setting. The non-default cases are currently overridden in ARMISelLowering. Just delete this until the list of calls and lowering decisions are separated. This was added back in 6402ad2. It appears to not be relevant for AArch64, where calls appear to never be used for these. It also appears to not be relevant for x86, where the default calls seem to always end up used anyway.

llvm-ci · 2025-08-04T02:12:36Z

LLVM Buildbot has detected a new failure on builder lldb-x86_64-debian running on lldb-x86_64-debian while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/28201

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: Host/./HostTests/75/125 (259 of 3128)
PASS: lldb-api :: functionalities/lazy-loading/TestLazyLoading.py (260 of 3128)
PASS: lldb-api :: functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py (261 of 3128)
PASS: lldb-api :: types/TestIntegerType.py (262 of 3128)
PASS: lldb-api :: functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py (263 of 3128)
PASS: lldb-api :: functionalities/exec/TestExec.py (264 of 3128)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx-simulators/unique_ptr/TestDataFormatterLibcxxUniquePtrSimulator.py (265 of 3128)
PASS: lldb-api :: python_api/type/TestTypeList.py (266 of 3128)
PASS: lldb-api :: functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py (267 of 3128)
PASS: lldb-api :: functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py (268 of 3128)
FAIL: lldb-api :: tools/lldb-dap/output/TestDAP_output.py (269 of 3128)
******************** TEST 'lldb-api :: tools/lldb-dap/output/TestDAP_output.py' FAILED ********************
Script:
--
/usr/bin/python3 /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/./lib --env LLVM_INCLUDE_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/include --env LLVM_TOOLS_DIR=/home/worker/2.0.1/lldb-x86_64-debian/build/./bin --arch x86_64 --build-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex --lldb-module-cache-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/worker/2.0.1/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/lldb --compiler /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/clang --dsymutil /home/worker/2.0.1/lldb-x86_64-debian/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/worker/2.0.1/lldb-x86_64-debian/build/./bin --lldb-obj-root /home/worker/2.0.1/lldb-x86_64-debian/build/tools/lldb --lldb-libs-dir /home/worker/2.0.1/lldb-x86_64-debian/build/./lib --cmake-build-type Release -t /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/tools/lldb-dap/output -p TestDAP_output.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 22.0.0git (https://github.com/llvm/llvm-project.git revision 5b528a1041fb6b64e5722f1bc600eb0617118a3e)
  clang revision 5b528a1041fb6b64e5722f1bc600eb0617118a3e
  llvm revision 5b528a1041fb6b64e5722f1bc600eb0617118a3e
Skipping the following test categories: ['libc++', 'msvcstl', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
Change dir to: /home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/tools/lldb-dap/output
runCmd: settings clear --all

output: 

runCmd: settings set symbols.enable-external-lookup false

output: 

runCmd: settings set target.inherit-tcc true

output: 

runCmd: settings set target.disable-aslr false

output: 

runCmd: settings set target.detach-on-error false

output:

arsenm mentioned this pull request Jul 15, 2025

RuntimeLibcalls: Really move default libcall handling to tablegen #148780

Merged

arsenm added backend:X86 llvm:ir tablegen labels Jul 15, 2025 — with Graphite App

This was referenced Jul 15, 2025

RuntimeLibcalls: Remove __muloti4 from default libcall set #148562

Merged

RuntimeLibcalls: Invert handling of 64-bit only libcalls #148571

Merged

arsenm requested review from DanielKristofKiss, dpaoliello, efriedma-quic, nikic and RKSimon July 15, 2025 06:19

This was referenced Jul 15, 2025

RuntimeLibcalls: Mostly move x86 configuration into tablegen #148575

Merged

RuntimeLibcalls: Stop opting out of exp10 #148604

Merged

arsenm added the backend:ARM label Jul 15, 2025 — with Graphite App

arsenm requested a review from ahmedbougacha July 15, 2025 06:19

arsenm marked this pull request as ready for review July 15, 2025 06:20

tgross35 reviewed Jul 15, 2025

View reviewed changes

This was referenced Jul 15, 2025

RuntimeLibcalls: Move __stack_chk_fail config to tablegen #148789

Merged

RuntimeLibcalls: Remove target check for sjlj config #148792

Merged

arsenm force-pushed the users/arsenm/runtime-libcalls/use-tablegen-default-handling branch from ef419d6 to f5462a6 Compare July 15, 2025 07:20

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch from 39867e3 to b5bbf7f Compare July 15, 2025 07:21

arsenm force-pushed the users/arsenm/runtime-libcalls/use-tablegen-default-handling branch from f5462a6 to 5843fba Compare July 28, 2025 02:43

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch from b5bbf7f to 0b21d22 Compare July 28, 2025 02:43

This was referenced Jul 28, 2025

RuntimeLibcalls: Add bitset for available libcalls #150869

Open

RuntimeLibcalls: Move __stack_smash_handler config to tablegen #150870

Open

arsenm force-pushed the users/arsenm/runtime-libcalls/use-tablegen-default-handling branch from 5843fba to a8d3505 Compare August 3, 2025 00:41

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch from 0b21d22 to 9404c93 Compare August 3, 2025 00:41

nikic approved these changes Aug 3, 2025

View reviewed changes

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch from 9404c93 to 20a6035 Compare August 3, 2025 16:32

arsenm force-pushed the users/arsenm/runtime-libcalls/use-tablegen-default-handling branch from a8d3505 to 744161e Compare August 3, 2025 16:32

Base automatically changed from users/arsenm/runtime-libcalls/use-tablegen-default-handling to main August 3, 2025 23:32

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch 2 times, most recently from b040c7a to d564efc Compare August 4, 2025 00:42

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch 6 times, most recently from 1545d0e to bd93ef9 Compare August 4, 2025 01:55

arsenm force-pushed the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch from bd93ef9 to 0c1bb90 Compare August 4, 2025 02:00

arsenm merged commit 5b528a1 into main Aug 4, 2025
7 of 9 checks passed

arsenm deleted the users/arsenm/runtime-libcalls/remove-darwin-half-convert-libcall-case branch August 4, 2025 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RuntimeLibcalls: Remove darwin override of half convert libcalls #148782

RuntimeLibcalls: Remove darwin override of half convert libcalls #148782

arsenm commented Jul 15, 2025

Uh oh!

arsenm commented Jul 15, 2025 •

edited

Loading

Uh oh!

llvmbot commented Jul 15, 2025 •

edited

Loading

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

tgross35 left a comment

Uh oh!

arsenm commented Aug 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

llvm-ci commented Aug 4, 2025

Uh oh!

Uh oh!

RuntimeLibcalls: Remove darwin override of half convert libcalls #148782

RuntimeLibcalls: Remove darwin override of half convert libcalls #148782

Conversation

arsenm commented Jul 15, 2025

Uh oh!

arsenm commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

arsenm commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

llvm-ci commented Aug 4, 2025

Uh oh!

Uh oh!

arsenm commented Jul 15, 2025 •

edited

Loading

llvmbot commented Jul 15, 2025 •

edited

Loading

arsenm commented Aug 4, 2025 •

edited

Loading