Skip to content

[Hexagon] Remove an unnecessary cast (NFC) #148870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

SB is already of MachineBasicBlock *SB.

@llvmbot
Copy link
Member

llvmbot commented Jul 15, 2025

@llvm/pr-subscribers-backend-hexagon

Author: Kazu Hirata (kazutakahirata)

Changes

SB is already of MachineBasicBlock *SB.


Full diff: https://github.com/llvm/llvm-project/pull/148870.diff

1 Files Affected:

  • (modified) llvm/lib/Target/Hexagon/HexagonConstPropagation.cpp (+1-1)
diff --git a/llvm/lib/Target/Hexagon/HexagonConstPropagation.cpp b/llvm/lib/Target/Hexagon/HexagonConstPropagation.cpp
index bb7814c5226fd..35da34ed0a899 100644
--- a/llvm/lib/Target/Hexagon/HexagonConstPropagation.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonConstPropagation.cpp
@@ -1005,7 +1005,7 @@ bool MachineConstPropagator::rewrite(MachineFunction &MF) {
       SmallVector<MachineBasicBlock*,2> ToRemove;
       for (MachineBasicBlock *SB : B->successors()) {
         if (!Targets.count(SB))
-          ToRemove.push_back(const_cast<MachineBasicBlock*>(SB));
+          ToRemove.push_back(SB);
         Targets.remove(SB);
       }
       for (MachineBasicBlock *MBB : ToRemove)

SB is already of MachineBasicBlock *SB.
@kazutakahirata kazutakahirata force-pushed the cleanup_20250715_cast_Hexagon branch from 650d9d0 to dcb72ee Compare July 15, 2025 23:43
@kazutakahirata kazutakahirata merged commit b454062 into llvm:main Jul 16, 2025
9 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250715_cast_Hexagon branch July 16, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants