[clang-doc] Precommit param comment test changes #150469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 24, 2025
|
@llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) ChangesFull diff: https://github.com/llvm/llvm-project/pull/150469.diff 1 Files Affected:
diff --git a/clang-tools-extra/test/clang-doc/basic-project.mustache.test b/clang-tools-extra/test/clang-doc/basic-project.mustache.test
index 4cf8bad32fd9d..807ba1319e393 100644
--- a/clang-tools-extra/test/clang-doc/basic-project.mustache.test
+++ b/clang-tools-extra/test/clang-doc/basic-project.mustache.test
@@ -259,7 +259,24 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
-HTML-CALC: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <h3>Parameters</h3>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>a</b> <div>
+HTML-CALC-NOT: <p> First integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>b</b> <div>
+HTML-CALC-NOT: <p> Second integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
@@ -299,7 +316,24 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
-HTML-CALC: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <h3>Parameters</h3>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>a</b> <div>
+HTML-CALC-NOT: <p> First integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>b</b> <div>
+HTML-CALC-NOT: <p> Second integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
@@ -319,6 +353,23 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <h3>Parameters</h3>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>a</b> <div>
+HTML-CALC-NOT: <p> First integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>b</b> <div>
+HTML-CALC-NOT: <p> Second integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
@@ -339,6 +390,23 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <h3>Parameters</h3>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>a</b> <div>
+HTML-CALC-NOT: <p> First integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <b>b</b> <div>
+HTML-CALC-NOT: <p> Second integer.</p>
+HTML-CALC-NOT: </div>
+HTML-CALC-NOT: <div>
+HTML-CALC-NOT: <p></p>
+HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
@@ -438,6 +506,20 @@ HTML-RECTANGLE: <p></p>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: <div>
HTML-RECTANGLE: <p></p>
+HTML-RECTANGLE-NOT: </div>
+HTML-RECTANGLE-NOT: <h3>Parameters</h3>
+HTML-RECTANGLE-NOT: <div>
+HTML-RECTANGLE-NOT: <b>width</b> <div>
+HTML-RECTANGLE-NOT: <p> Width of the rectangle.</p>
+HTML-RECTANGLE-NOT: </div>
+HTML-RECTANGLE-NOT: <div>
+HTML-RECTANGLE-NOT: <p></p>
+HTML-RECTANGLE-NOT: </div>
+HTML-RECTANGLE-NOT: </div>
+HTML-RECTANGLE-NOT: <div>
+HTML-RECTANGLE-NOT: <b>height</b> <div>
+HTML-RECTANGLE-NOT: <p> Height of the rectangle.</p>
+HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: </div>
@@ -577,6 +659,12 @@ HTML-CIRCLE: <p></p>
HTML-CIRCLE: </div>
HTML-CIRCLE: <div>
HTML-CIRCLE: <p></p>
+HTML-CIRCLE-NOT: </div>
+HTML-CIRCLE-NOT: <h3>Parameters</h3>
+HTML-CIRCLE-NOT: <div>
+HTML-CIRCLE-NOT: <b>radius</b> <div>
+HTML-CIRCLE-NOT: <p> Radius of the circle.</p>
+HTML-CIRCLE-NOT: </div>
HTML-CIRCLE: </div>
HTML-CIRCLE: </div>
HTML-CIRCLE: </div>
|
ilovepi
reviewed
Jul 24, 2025
| @@ -259,7 +259,24 @@ HTML-CALC: <p></p> | |||
| HTML-CALC: </div> | |||
| HTML-CALC: <div> | |||
| HTML-CALC: <p></p> | |||
| HTML-CALC: </div> | |||
| HTML-CALC-NOT: </div> | |||
There was a problem hiding this comment.
Won't this check break when it matches the at the end?
There was a problem hiding this comment.
All these tests pass on my machine.
|
Since you're just dropping the NOT prefix in the next patch, I'd consider just squashing them together. Left a similar comment up the stack. |
evelez7
force-pushed
the
users/evelez7/clang-doc-function-comments
branch
from
5d9ea9d to
7ca4dab
Compare
evelez7
force-pushed
the
users/evelez7/clang-doc-precommit-param-comments
branch
from
625b470 to
f678074
Compare
evelez7
force-pushed
the
users/evelez7/clang-doc-function-comments
branch
from
7ca4dab to
47d132b
Compare
evelez7
force-pushed
the
users/evelez7/clang-doc-precommit-param-comments
branch
from
f678074 to
e2e10a6
Compare
evelez7
force-pushed
the
users/evelez7/clang-doc-function-comments
branch
from
47d132b to
b388252
Compare
evelez7
force-pushed
the
users/evelez7/clang-doc-precommit-param-comments
branch
from
e2e10a6 to
6f21379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.