Skip to content

[RootSignature] Add StaticSampler testing #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 2, 2025
Merged

[RootSignature] Add StaticSampler testing #367

merged 11 commits into from
Sep 2, 2025

Conversation

inbelic
Copy link
Contributor

@inbelic inbelic commented Aug 20, 2025 •
edited
Loading

This pr adds testing for using a StaticSampler to describe a Sampler resource.

It checks both default and specified parameters are generated correctly.

Resolves #261.

@inbelic inbelic force-pushed the inbelic/static-sampler branch from d952df4 to b132a88 Compare August 20, 2025 04:42
@inbelic inbelic marked this pull request as ready for review August 22, 2025 18:36
llvm-beanz
llvm-beanz reviewed Aug 22, 2025
View reviewed changes
test/Feature/RootSignatures/StaticSamplers.test Outdated
...
#--- end

# UNSUPPORTED: Clang
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XFAIL with the appropriate issue is preferred.

alsepkow
alsepkow reviewed Aug 22, 2025
View reviewed changes
alsepkow
alsepkow reviewed Aug 22, 2025
View reviewed changes
@inbelic inbelic force-pushed the inbelic/static-sampler branch from 00ecdc7 to 6afdd40 Compare August 28, 2025 16:10
@inbelic inbelic added the test-all When applied to a PR this will opt-in to additional pre-merge test configurations.. label Aug 28, 2025
@inbelic inbelic force-pushed the inbelic/static-sampler branch from ac465aa to 04ea569 Compare September 1, 2025 22:17
@inbelic inbelic removed the test-all When applied to a PR this will opt-in to additional pre-merge test configurations.. label Sep 2, 2025
@inbelic
Copy link
Contributor Author

inbelic commented Sep 2, 2025

From running test-all, here, it has the following behaviour:

  • CLANG: XFAILS as expected
  • WARP: Supports derivatives and passes
  • NVIDIA: Supports derivatives and passes
  • AMD: Supports derivatives and passes
  • QC: Supports derivatives and passes
  • INTEL: Does not support derivates and marked as UNSUPPORTED
  • VK: UNSUPPORTED

llvm-beanz
llvm-beanz reviewed Sep 2, 2025
View reviewed changes
llvm-beanz
llvm-beanz approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment otherwise looks good.

@inbelic inbelic merged commit 89a9082 into llvm:main Sep 2, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llvm-beanz llvm-beanz llvm-beanz approved these changes

+1 more reviewer

@alsepkow alsepkow alsepkow left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HLSL] Add execution testing of Samplers Root Signatures
3 participants
@inbelic @alsepkow @llvm-beanz