Add GetDimensions tests for {RW}Buffer and {RW}ByteAddressBuffer #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move GetDimensions tests for structured buffers into directory with other tests related to structured buffers. Rename RawBuffers directory to ByteAddressBuffers (the name was confusing, because structured buffers are also raw buffers and we usually have these separate). Closes llvm#448
bogner
reviewed
Oct 8, 2025
bogner
approved these changes
Oct 8, 2025
farzonl
reviewed
Oct 15, 2025
farzonl
reviewed
Oct 15, 2025
farzonl
reviewed
Oct 15, 2025
farzonl
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GetDimensionstests for{RW}Bufferand{RW}ByteAddressBuffer.Update existing
GetDimensionstests for structured buffers to useResults:construct instead ofFileCheckto verify the results, and move them into directory with other tests related to structured buffers.Rename
RawBuffersdirectory toByteAddressBuffers. The name was confusing because structured buffers are also raw buffers, and we usually have these separate.Closes #448