Adds tests for isnan(). #466
Conversation
test/Feature/HLSLLib/isnan.16.test
Outdated
| ... | ||
| #--- end | ||
|
|
||
| # llvm/llvm-project#141089 |
There was a problem hiding this comment.
the issue you linked is closed llvm/llvm-project#141089 are you sure this should still xfail for clang-vulkan?
There was a problem hiding this comment.
Clang-Vulkan XFAIL removed.
| # llvm/llvm-project#141089 | ||
| # XFAIL: Clang-Vulkan | ||
|
|
||
| # https://github.com/llvm/llvm-project/issues/145571 |
There was a problem hiding this comment.
We added the isnan emulation see https://github.com/llvm/llvm-project/pull/157505/files this should work for clang.
There was a problem hiding this comment.
I don't have an nVidia GPU, so I suppose I can't test for DirectX-NV?
There was a problem hiding this comment.
We don't run the nvidia gpu runner yet on the PR runs. and the only way to manually invoke it would be if you had a branch on this repository. There doesn't apear to be anyway to do that with a fork. That said I feel confident that if you are seeing the emulation passing on amd\intel for sm 6.8 and lower then it should pass for nvidia too since we won't be emitting the opcode that would blow things up.
There was a problem hiding this comment.
If you add a test-all label to the PR then it should run against all the machines in the offload tester lab.
https://github.com/llvm/offload-test-suite/blob/main/docs/CI.md
If this doesn't work for PRs from forks we should update these docs!
damyanp
added
the
test-all
3 participants
Test values taken from the isinf() tests; others may be relevant.