Implement error and unauthorized #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
approved these changes
Jun 26, 2025
Collaborator
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
Thanks for adding these crucial components to this package!
index.js
Outdated
Comment on lines
136
to
137
| // LocalStack is adding `appendError` to console, allowing to push errors to context.outErrors | ||
| console.appendError(error) |
Collaborator
There was a problem hiding this comment.
This will impact users who want to use this package directly (outside of LocalStack 😱 ) right?
I guess the workaround is to add an appendError attribute to the console global in their own code, so perhaps this will encourage more people to use LocalStack!
Member
Author
There was a problem hiding this comment.
Since it is inside a if block, the previous behaviour of console.error will apply when console.appendError is undefined. So it will still work as it previously did.
With that consideration in mind though, I will remove the TODO and leave a comment to explain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements
util.errorandutil.unauthorized. Along with an improvement onutil.appendErrorto utilize LocalStack override ofconsoleto append errors to the context.