QueryTimeoutError only takes one argument. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TravisCI test failed, but it's a problem with the test environment and not this PR: |
|
@nickelser You might want to fix |
Re-enable expanded test suite
Rails 5.2 support
Add Snowflake Adapter
Rails 6 support
allow rails 7
divoxx
pushed a commit
to doximity/odbc_adapter
that referenced
this pull request
Aug 11, 2023
* MOJ-366 Two updates for added functionality - Varient & object fields now support store_accessor attribute on models - Insert attribute stripper now validates the record before stripping the attributes, but then disables validation when doing the initial save so that it doesn't fail validation when required attributes are stripped off. * MOJ-366 Switched InsertAttributeStripper back to use calling the base function, so that it will always correctly return false or raise the error depending on if save or save! is called. * MOJ-366 Need to use options, not temp_options here. temp_options doesn't even exist yet.
* Update Rubocop and fix some rules * Rubocop updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the
wrong number of arguments (given 2, expected 0..1)exception with timeouts.