Skip to content

cadvisor node filter daemonset #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yotamloe wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cadvisor node filter daemonset #656

yotamloe wants to merge 2 commits into from

Conversation

@yotamloe
Copy link
Contributor

@yotamloe yotamloe commented Aug 24, 2025 •
edited
Loading

Description

  • Add node filter for cadvisor job in daemonsetConfig

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

Copilot AI reviewed Aug 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

ralongit
ralongit approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ralongit ralongit ralongit approved these changes

@8naama 8naama 8naama approved these changes

@bardabun bardabun Awaiting requested review from bardabun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yotamloe @ralongit @8naama