refactoring #1343
Closed
refactoring #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you, more changes are useful. But there is a bit of case I'd like to keep the original struct name to more clearly. |
huacnlee
reviewed
Oct 10, 2025
|
|
||
| fn open_drawer_at<F>(&mut self, placement: Placement, cx: &mut App, build: F) | ||
| where | ||
| F: Fn(Drawer, &mut Window, &mut App) -> Drawer + 'static, |
Member
There was a problem hiding this comment.
&mut Window, &mut App is a standard in entire of the GPUI application, so we can keep the original style.
huacnlee
reviewed
Oct 10, 2025
| F: FnOnce(&mut Self, &mut Window, &mut Context<Self>) -> R, | ||
| { | ||
| let root = window | ||
| .root::<Root>() |
Member
There was a problem hiding this comment.
In this case, I'd like to use Root, not Self.
huacnlee
reviewed
Oct 10, 2025
| } | ||
|
|
||
| /// Check if the self is equal to the given index path (Same section and row). | ||
| pub fn eq_row(&self, index: IndexPath) -> bool { |
Member
There was a problem hiding this comment.
As an argument, I'd like to keep original style.
huacnlee
reviewed
Oct 10, 2025
| AlertVariant::Info => cx.theme().info, | ||
| AlertVariant::Success => cx.theme().success, | ||
| AlertVariant::Warning => cx.theme().warning, | ||
| AlertVariant::Error => cx.theme().danger, |
Member
There was a problem hiding this comment.
This is good, now code is shorter.
huacnlee
reviewed
Oct 10, 2025
|
|
||
| impl ThemeColor { | ||
| /// Create a new `ThemeColor` from a `ThemeConfig`. | ||
| pub(crate) fn apply_config(&mut self, config: &ThemeConfig, default_theme: &ThemeColor) { |
huacnlee
reviewed
Oct 10, 2025
| let mode = mode.into(); | ||
| if !cx.has_global::<Theme>() { | ||
| let mut theme = Theme::default(); | ||
| if !cx.has_global::<Self>() { |
Member
There was a problem hiding this comment.
Downcast or like this, I'd like revert.
huacnlee
reviewed
Oct 10, 2025
|
|
||
| impl Node { | ||
| fn render_list_item( | ||
| item: &Node, |
huacnlee
reviewed
Oct 10, 2025
| } | ||
|
|
||
| /// Add a ResizablePanelGroup as a child to the group. | ||
| pub fn group(self, group: ResizablePanelGroup) -> Self { |
huacnlee
reviewed
Oct 10, 2025
| self | ||
| } | ||
|
|
||
| pub(crate) fn active_submenu(&self) -> Option<Entity<PopupMenu>> { |
huacnlee
reviewed
Oct 10, 2025
| } | ||
| } | ||
|
|
||
| pub fn add_child(&mut self, panel: PanelState) { |
huacnlee
reviewed
Oct 10, 2025
| if let Some(view) = panel { | ||
| if let Ok(tab_panel) = view.view().downcast::<TabPanel>() { | ||
| Some(tab_panel) | ||
| } else if let Ok(stack_panel) = view.view().downcast::<StackPanel>() { |
huacnlee
reviewed
Oct 10, 2025
| if let Some(view) = first_panel { | ||
| if let Ok(tab_panel) = view.view().downcast::<TabPanel>() { | ||
| Some(tab_panel) | ||
| } else if let Ok(stack_panel) = view.view().downcast::<StackPanel>() { |
huacnlee
reviewed
Oct 10, 2025
| pub(super) fn replace_panel( | ||
| &mut self, | ||
| old_panel: Arc<dyn PanelView>, | ||
| new_panel: Entity<StackPanel>, |
huacnlee
reviewed
Oct 10, 2025
| fn assert_panel_is_valid(&self, panel: &Arc<dyn PanelView>) { | ||
| assert!( | ||
| panel.view().downcast::<TabPanel>().is_ok() | ||
| || panel.view().downcast::<StackPanel>().is_ok(), |
huacnlee
reviewed
Oct 10, 2025
| /// Initialize the panel registry. | ||
| pub(crate) fn init(cx: &mut App) { | ||
| if let None = cx.try_global::<PanelRegistry>() { | ||
| cx.set_global(PanelRegistry::new()); |
huacnlee
reviewed
Oct 10, 2025
| /// Set `None` in `sizes` to make the index of panel have auto size. | ||
| pub fn split_with_sizes( | ||
| axis: Axis, | ||
| items: Vec<DockItem>, |
This was referenced Oct 10, 2025
Member
|
Since this PR has received no feedback for a long time and code conflicts, I've temporarily closed it. If you wish to continue, you can reopen it and refine it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.