Skip to content

Conversation

@yulken
Copy link

@yulken yulken commented Aug 14, 2025

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9064

What this PR does / why we need it:

Updating explicit dependencies

Special notes for your reviewer:

Additional documentation or context

@yulken yulken requested a review from a team August 21, 2025 13:36
@derekbit derekbit force-pushed the bugfix/delete-parent-v2-volume-head branch 2 times, most recently from f332f35 to 69a3162 Compare August 31, 2025 13:46
@derekbit derekbit force-pushed the bugfix/delete-parent-v2-volume-head branch from 69a3162 to 38e47b9 Compare September 11, 2025 03:00
@yulken yulken force-pushed the bugfix/delete-parent-v2-volume-head branch 2 times, most recently from 38e47b9 to b7c231a Compare September 17, 2025 16:00
@derekbit derekbit force-pushed the bugfix/delete-parent-v2-volume-head branch from b7c231a to f2c2778 Compare September 23, 2025 03:04
@yulken yulken force-pushed the bugfix/delete-parent-v2-volume-head branch from f2c2778 to d06cae3 Compare September 23, 2025 13:16
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Oct 24, 2025
@yulken yulken force-pushed the bugfix/delete-parent-v2-volume-head branch from d06cae3 to f4685d1 Compare October 24, 2025 11:30
@yulken
Copy link
Author

yulken commented Oct 24, 2025

@derekbit please let me know if there's anything left to do here

@shuo-wu
Copy link
Contributor

shuo-wu commented Oct 24, 2025

@yulken Hi, Caio. We need to update the code in https://github.com/longhorn/longhorn-spdk-engine first, then update go.mod dependency commit ID and run go mod tidy && go mod vendor for this repo.

@shuo-wu
Copy link
Contributor

shuo-wu commented Oct 24, 2025

Besides, for this feature, we need to check if there is any similar check in the longhorn-manager repo as well.

@yulken
Copy link
Author

yulken commented Oct 24, 2025

Thanks @shuo-wu, I will do it.

@github-actions github-actions bot removed the stale label Oct 25, 2025
@yulken yulken marked this pull request as draft October 28, 2025 19:36
@yulken yulken force-pushed the bugfix/delete-parent-v2-volume-head branch from f4685d1 to 4649c71 Compare October 30, 2025 14:51
@yulken yulken force-pushed the bugfix/delete-parent-v2-volume-head branch from 4649c71 to ab81068 Compare October 30, 2025 14:52

toolchain go1.25.3

replace github.com/longhorn/longhorn-spdk-engine => github.com/yulken/longhorn-spdk-engine v0.0.0-e05509dbff19ffa9b4b48ceb3831654c1e44f899
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove later

@yulken
Copy link
Author

yulken commented Oct 30, 2025

@yulken yulken changed the title fix: allow removal of v2 volume head's parent feat: update spdk dependencies Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants