Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion src/Concerns/AsObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@

namespace Lorisleiva\Actions\Concerns;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Routing\RouteDependencyResolverTrait;
use Illuminate\Support\Fluent;
use ReflectionMethod;

trait AsObject
{
use RouteDependencyResolverTrait;

/**
* @return static
*/
Expand All @@ -19,7 +24,10 @@ public static function make()
*/
public static function run(mixed ...$arguments): mixed
{
return static::make()->handle(...$arguments);
$instance = static::make();
$arguments = static::resolveModelBindings($instance, 'handle', $arguments);

return app()->call([$instance, 'handle'], $arguments);
}

public static function runIf(bool $boolean, mixed ...$arguments): mixed
Expand All @@ -31,4 +39,44 @@ public static function runUnless(bool $boolean, mixed ...$arguments): mixed
{
return static::runIf(! $boolean, ...$arguments);
}

protected static function resolveModelBindings(object $instance, string $method, array $arguments): array
{
if (! method_exists($instance, $method)) {
return $arguments;
}

$reflection = new ReflectionMethod($instance, $method);
$parameters = $reflection->getParameters();
$resolved = [];

foreach ($parameters as $index => $parameter) {
if (! array_key_exists($index, $arguments)) {
continue;
}

$value = $arguments[$index];

if (is_object($value)) {
$resolved[$parameter->getName()] = $value;
continue;
}

$type = $parameter->getType();
if ($type && ! $type->isBuiltin() && class_exists($type->getName())) {
$typeName = $type->getName();

if (is_subclass_of($typeName, Model::class)) {
if (is_scalar($value) && $value !== null) {
$resolved[$parameter->getName()] = $typeName::findOrFail($value);
continue;
}
}
}

$resolved[$parameter->getName()] = $value;
}

return $resolved;
}
}
33 changes: 33 additions & 0 deletions tests/AsObjectWithModelBindingNullableTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

namespace Lorisleiva\Actions\Tests;

use Lorisleiva\Actions\Concerns\AsObject;
use Lorisleiva\Actions\Tests\Stubs\User;

class AsObjectWithModelBindingNullableTest
{
use AsObject;

public function handle(?User $user): ?User
{
return $user;
}
}

it('handles nullable model parameters with null value', function () {
$result = AsObjectWithModelBindingNullableTest::run(null);

expect($result)->toBeNull();
});

it('handles nullable model parameters with scalar value', function () {
loadMigrations();
createUser(['id' => 1, 'name' => 'John']);

$result = AsObjectWithModelBindingNullableTest::run(1);

expect($result)->toBeInstanceOf(User::class);
expect($result->id)->toBe(1);
});

42 changes: 42 additions & 0 deletions tests/AsObjectWithModelBindingOptionalParamTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php

namespace Lorisleiva\Actions\Tests;

use Lorisleiva\Actions\Concerns\AsObject;
use Lorisleiva\Actions\Tests\Stubs\User;

class AsObjectWithModelBindingOptionalParamTest
{
use AsObject;

public function handle(User $user, string $status = 'active'): array
{
return [
'user' => $user,
'status' => $status,
];
}
}

it('handles optional parameters correctly', function () {
loadMigrations();
createUser(['id' => 1, 'name' => 'John']);

$result = AsObjectWithModelBindingOptionalParamTest::run(1);

expect($result['user'])->toBeInstanceOf(User::class);
expect($result['user']->id)->toBe(1);
expect($result['status'])->toBe('active');
});

it('handles optional parameters with provided value', function () {
loadMigrations();
createUser(['id' => 1, 'name' => 'John']);

$result = AsObjectWithModelBindingOptionalParamTest::run(1, 'inactive');

expect($result['user'])->toBeInstanceOf(User::class);
expect($result['user']->id)->toBe(1);
expect($result['status'])->toBe('inactive');
});

52 changes: 52 additions & 0 deletions tests/AsObjectWithModelBindingTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?php

namespace Lorisleiva\Actions\Tests;

use Illuminate\Database\Eloquent\ModelNotFoundException;
use Lorisleiva\Actions\Concerns\AsObject;
use Lorisleiva\Actions\Tests\Stubs\User;

class AsObjectWithModelBindingTest
{
use AsObject;

public function handle(User $user): User
{
return $user;
}
}

it('resolves model binding when passing scalar value to run()', function () {
loadMigrations();
$user = createUser([
'id' => 42,
'name' => 'John Doe',
]);

$result = AsObjectWithModelBindingTest::run(42);

expect($result)->toBeInstanceOf(User::class);
expect($result->id)->toBe(42);
expect($result->name)->toBe('John Doe');
});

it('works when passing model instance directly', function () {
loadMigrations();
$user = createUser([
'id' => 42,
'name' => 'John Doe',
]);

$result = AsObjectWithModelBindingTest::run($user);

expect($result)->toBe($user);
expect($result->id)->toBe(42);
});

it('throws exception when model not found', function () {
loadMigrations();

expect(fn() => AsObjectWithModelBindingTest::run(999))
->toThrow(ModelNotFoundException::class);
});