DM-51311: Prompt Processing hangs on certain operations #352
+110
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that activator.py is an importable module, and not an executable, it should list the members intended to be imported elsewhere.
The GracefulShutdownInterrupt and generic error handlers were identical except for one line. It's easier (if slightly slower?) to use an explicit isinstance check than to maintain two different handlers.
This lets the worker be called with a timeout, with the timeout's implementation details hidden from process_visit's clients.
kfindeisen
force-pushed
the
tickets/DM-51311
branch
from
12f856e to
9df10fd
Compare
kfindeisen
force-pushed
the
tickets/DM-51311
branch
from
9df10fd to
e83c320
Compare
Like GracefulShutdownInterrupt, TimeoutInterrupt is raised asynchronously, may leave the program in an invalid state, and may be caught prematurely.
The timeout uses an alarm and a signal handler to interrupt application code at will. This implementation is fairly robust, but assumes that nothing else (especially sleep functions) uses SIGALRM and has the usual caveats of signal handlers raising exceptions.
kfindeisen
force-pushed
the
tickets/DM-51311
branch
from
1dce37c to
035abdd
Compare
While Logger.exception is a handy way of printing stack traces, any log message can include them. Include the stack trace as part of critical logs instead of in a separate message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a signal handler to cut off
process_visit callsthat take longer than a configurable limit. The cutoff is soft, in the sense thatprocess_visitstill has a chance to perform cleanup as if during a pod shutdown. This means there is a chance that a hangup will trigger a timeout, then another hangup on Butler export; this should be rare enough that we can ignore it.