Added Columns property in order to get extra commands based off it #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorocampos
commented
Jan 26, 2024
| { | ||
| public abstract partial class BaseCommandEmitter : ICommandEmitter | ||
| { | ||
| public int Columns { get; set; } = 42; |
There was a problem hiding this comment.
I wasn't sure about the default for this, 42 columns is what the majority of printers I dealt with in Brazil had, but as an alternative, we could just not set any default value for the property, make it a getter-only property and force the constructor to receive the column count. However that would be a breaking change, so between having a random number as default and breaking existing code from others, I decided to stick with a default value.
What do you think @lukevp ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses suggestions of #210 and #147
A new property that holds the column count so it's easier to write horizontal line and align texts to both left and right on the same line.