Skip to content

Conversation

@eruber
Copy link

@eruber eruber commented Jul 6, 2018

This is want i did to fix issue 301.

Not sure why lines 155 and 217 are showing up here; I don't remember adding those two blanks lines.

@AntumDeluge
Copy link
Contributor

#301

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like you've collected a bunch of stuff that isn't just to fix issue #301 and is not relevant to be merged to the canonical project.

Would you happen to still be around and in a position to fix your branch or split this up into a branch with the relevant bit(s)? I'm happy to facilitate a fix getting merged, but this isn't ready for that.


Copyright (C) 2011-2012 Steve Donovan.

## Fork of Steve Donovan's LDoc that fixes issue 301 and adds the following tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we consider merging this, you should remove anything that suggests this is a fork. We're merging to the bonefied original here ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants