Skip to content

[wip] handle union/optional fields in a tuple #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[wip] handle union/optional fields in a tuple #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pynamodb_attributes/unicode_delimited_tuple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,19 @@ def deserialize(self, value: str) -> T:
field_types = getattr(self.tuple_type, '_field_types', None)
if fields and field_types:
values = value.split(self.delimiter, maxsplit=len(fields))
return self.tuple_type(**{f: field_types[f](v) for f, v in zip(fields, values)}) # type: ignore
tuple_vals = {}
for f, v in zip(fields, values):
if field_types[f].__module__ == 'builtins':
tuple_vals[f] = field_types[f](v)
elif field_types[f].__module__ == 'typing' and field_types[f].__origin__ == typing.Union:
for arg_type in field_types[f].__args__:
try:
tuple_vals[f] = arg_type(v)
break
except Exception:
continue

return self.tuple_type(**tuple_vals) # type: ignore
else:
return self.tuple_type(value.split(self.delimiter)) # type: ignore

Expand Down