Skip to content
This repository was archived by the owner on Aug 25, 2021. It is now read-only.

Adding support for setting proxy on Client #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adding support for setting proxy on Client #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f81cbd
RestSharp updated to version 105.0.1
KindDragon Mar 22, 2015
bc79290
Add TreatWarningsAsErrors to all projects
mnaoumov Mar 28, 2015
46304b5
Merge pull request #1 from mnaoumov/fix-2739
KindDragon Mar 31, 2015
2402759
Add support for setting proxy on Client
Jan 24, 2017
3925dbd
Add support for setting proxy on Client
Jan 24, 2017
e3c9975
Merge branch 'master' into master
jcl8746 Jan 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Git.hub.Demo/Git.hub.Demo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<DefineConstants>DEBUG;TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Copy link
Contributor

@sharwell sharwell Jan 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 A better way to do this is using a rule set file to actually set the severity of the original issue to Error instead of Warning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, most of these changes are not my own but things that existed in master but not v0.1.1.0

If some of these changes don't make sense, could someone create a branch on the tag v0.1.1.0 so that I can make a pull request with only my changes?

Or should I revert some of the commits in this pull request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcl8746 No problem, just putting the info out there for the future 😄

</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x86' ">
<PlatformTarget>x86</PlatformTarget>
Expand All @@ -32,6 +33,7 @@
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
Expand Down
13 changes: 13 additions & 0 deletions Git.hub/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using RestSharp;

namespace Git.hub
Expand Down Expand Up @@ -50,6 +51,18 @@ public void setOAuth2Token(string token)
client.Authenticator = new OAuth2AuthHelper(token);
else
client.Authenticator = null;
}

/// <summary>
/// Sets the client to use a proxy
/// </summary>
/// <param name="address">proxy address</param>
public void setProxyAddress(string address)
{
if (address != null)
client.Proxy = new WebProxy(address);
else
client.Proxy = null;
}

/// <summary>
Expand Down
6 changes: 4 additions & 2 deletions Git.hub/Git.hub.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
<DefineConstants>DEBUG;TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
Expand All @@ -32,11 +33,12 @@
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<Reference Include="RestSharp, Version=104.2.0.0, Culture=neutral, processorArchitecture=MSIL">
<Reference Include="RestSharp, Version=105.0.1.0, Culture=neutral, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\RestSharp.104.2.0\lib\net4-client\RestSharp.dll</HintPath>
<HintPath>..\..\..\packages\RestSharp.105.0.1\lib\net4-client\RestSharp.dll</HintPath>
</Reference>
<Reference Include="System" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Git.hub/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="RestSharp" version="104.2.0" targetFramework="net40-Client" />
<package id="RestSharp" version="105.0.1" targetFramework="net40-Client" />
</packages>