-
Couldn't load subscription status.
- Fork 9.4k
Fix admin got auto logged out when displaying large number of product reviews #40227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
|
Hi @imran9935. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
|
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @imran9935,
Thank you for your contribution!
Please fix the the failed failed static and integration tests. and have a look into the below review comment.
| * @return int|false | ||
| */ | ||
| protected function _findItemPositionByValue($value) | ||
| private function getRelativeReviewId($id, $operator, $order) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add return type for this method
| * | ||
| * @return array | ||
| */ | ||
| public function getResultingIds() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this method could be backward incompatible change.
Fixed Issues
Fixes : Admin got auto logged out when product reviews data is more than 28,000 at Marketing > All Reviews
Description (*)
Admin gets automatically logged out when opening the 'All Reviews' section in Marketing. This occurs for products with more than 28,000 reviews, as the system cannot handle such a large volume at once.
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)