[WIP ]feat: update user and organization metadata #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pajgo-feat/delete-inactive-users #428 +/- ##
===================================================================
Coverage ? 94.54%
===================================================================
Files ? 129
Lines ? 2366
Branches ? 0
===================================================================
Hits ? 2237
Misses ? 129
Partials ? 0
Continue to review full report at Codecov.
|
pajgo
changed the title
AVVS
reviewed
Sep 26, 2019
test/suites/updateMetadata.js
Outdated
| }); | ||
|
|
||
| it('must be able to run dynamic scripts / namespace fully available', function test() { | ||
| const dispatch = simpleDispatcher(this.users.router); |
There was a problem hiding this comment.
теперь можно this.users.dispatch использовать если добавить INTERNAL транспорт в action
AVVS
reviewed
Sep 26, 2019
test/suites/updateMetadata.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('must be able to run dynamic scripts / namespace fully available', function test() { |
There was a problem hiding this comment.
предпочтительнее async использовать теперь
* promise to async
pajgo
changed the base branch from
master
to
pajgo-feat/delete-inactive-users
* remove key validation
* promise to async
* remove key validation
pajgo
force-pushed
the
pajgo-feat/delete-inactive-users
branch
from
25186e7 to
d9f0aad
Compare
* test fix -> sentinel response order
|
Closed with re at #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub task for Inactive users delete.
Added audience tracking and moved script logic to the LUA Script.