Skip to content

Conversation

shattered
Copy link
Contributor

No description provided.

@rb6502 rb6502 merged commit 103de01 into mamedev:master Oct 12, 2025
7 checks passed
@cuavas
Copy link
Member

cuavas commented Oct 13, 2025

This doesn’t meet basic standards:

  • The device descriptions are far too generic, e.g. “Printer Interface” is completely unsuitable when these are globally identifying names across all of MAME.
  • Superfluous semicolons on inline functions.
  • Cold member functions not marked cold.
  • Directly #including sound.h from headers for some weird reason (you’re supposed to get it via emu.h).
  • Headers #include stuff only needed in implementation (e.g. speaker.h).
  • Device classes declared in headers when they realistically will only be accessed through interfaces.
  • bk_covox_device::m_data seems to be completely unnecessary – leftover copy/paste from loopback device?
  • Unnecessary overridden member functions that just slow down compilation (e.g. all the empty device_reset).
  • Useless #define VERBOSE 0 in files that don’t have any logging and don’t even #include "logmacro.h" – this will confuse people looking for the additional logging switching it to 1 should enable.

I’m not cleaning this one up myself. I’m sick of people just assuming I’ll do it. If it isn’t cleaned up tomorrow, I’m reverting it.

@rb6502
Copy link
Contributor

rb6502 commented Oct 13, 2025

@shattered You got this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants