-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Prevent NTSC/PAL NES from loading games that need the Expansion port #14265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change prevents loading all variants of Family Basic carts on non-Japanese hardware. Since the systems lack the expansion hardware to use the keyboard (and consequentially, the audio port for the tape deck), this renders them unusable and causes the same issues that were mentioned in 8443.
I'm okay with the principle. However does this also means that anything with an |
... hold on a sec. I just noticed Stadium Events (US/PAL) has no |
Stadium Events uses Power Pad that plugs into controller port, not the
Family Trainer controller that plugs into the expansion port
…On Thu, Oct 9, 2025 at 4:36 PM FoxhackDN ***@***.***> wrote:
*FoxhackDN* left a comment (mamedev/mame#14265)
<#14265 (comment)>
I'm okay with the principle. However does this also means that *anything*
with an exp_default should be filtered out, which means all the Family
Trainer games as well? If true I suggest to rename the compatibility filter
as exp instead of fbasic.
... hold on a sec. I just noticed Stadium Events (US/PAL) has no
exp_default, I don't think the game is even playable without the Power
Pad. Is this by design?
—
Reply to this email directly, view it on GitHub
<#14265 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGSVPDMHPW3J3RCFGWWAG33WZXHJAVCNFSM6AAAAACIJNEDD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBWGE3TQMZUGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Yeah, and I assumed If this isn't used for non-JP systems, then okay. I had no idea. I'll make the suggested changes later today and submit them after testing. |
Is there a reason you didn’t express this positively in the code by adding an “exp” filter to systems with the expansion port? |
I only had examples where the negative was used as a reference - specifically, the CD-i and its filter to prevent discs that required the DVC expansion from being loaded. I'm not opposed to someone cleaning the code up, but I'm not experienced enough to know how to do it properly. |
This change prevents loading all variants of Family Basic carts and Family Trainer games on non-Japanese hardware. Since stock systems lack the expansion port to use the keyboard (and consequentially, the audio port for the tape deck), and the Family Trainer pad uses a different interface compared to the US / PAL releases, this renders them unusable. It also causes the same issues that were mentioned in MAMETesters bug 8443 with the Family Basic games.
Also added Family Trainer support to Family Trainer 6 and 10 via the software list.