Skip to content

Conversation

FoxhackDN
Copy link
Contributor

@FoxhackDN FoxhackDN commented Oct 4, 2025

This change prevents loading all variants of Family Basic carts and Family Trainer games on non-Japanese hardware. Since stock systems lack the expansion port to use the keyboard (and consequentially, the audio port for the tape deck), and the Family Trainer pad uses a different interface compared to the US / PAL releases, this renders them unusable. It also causes the same issues that were mentioned in MAMETesters bug 8443 with the Family Basic games.

Also added Family Trainer support to Family Trainer 6 and 10 via the software list.

This change prevents loading all variants of Family Basic carts on non-Japanese hardware. Since the systems lack the expansion hardware to use the keyboard (and consequentially, the audio port for the tape deck), this renders them unusable and causes the same issues that were mentioned in 8443.
@angelosa
Copy link
Member

angelosa commented Oct 9, 2025

I'm okay with the principle. However does this also means that anything with an exp_default should be filtered out, which means all the Family Trainer games as well? If true I suggest to rename the compatibility filter as exp instead of fbasic.

@FoxhackDN
Copy link
Contributor Author

I'm okay with the principle. However does this also means that anything with an exp_default should be filtered out, which means all the Family Trainer games as well? If true I suggest to rename the compatibility filter as exp instead of fbasic.

... hold on a sec. I just noticed Stadium Events (US/PAL) has no exp_default, I don't think the game is even playable without the Power Pad. Is this by design?

@etabeta78
Copy link
Contributor

etabeta78 commented Oct 9, 2025 via email

@FoxhackDN
Copy link
Contributor Author

FoxhackDN commented Oct 9, 2025

Stadium Events uses Power Pad that plugs into controller port, not the Family Trainer controller that plugs into the expansion port

Yeah, and I assumed exp_default would boot the game with the necessary device already plugged in.

If this isn't used for non-JP systems, then okay. I had no idea. I'll make the suggested changes later today and submit them after testing.

@FoxhackDN FoxhackDN changed the title Prevent NTSC/PAL NES from loading Basic carts Prevent NTSC/PAL NES from loading games that need the Expansion port Oct 9, 2025
@galibert galibert merged commit d6fd0a4 into mamedev:master Oct 11, 2025
7 checks passed
@cuavas
Copy link
Member

cuavas commented Oct 12, 2025

Is there a reason you didn’t express this positively in the code by adding an “exp” filter to systems with the expansion port?

@FoxhackDN
Copy link
Contributor Author

Is there a reason you didn’t express this positively in the code by adding an “exp” filter to systems with the expansion port?

I only had examples where the negative was used as a reference - specifically, the CD-i and its filter to prevent discs that required the DVC expansion from being loaded. I'm not opposed to someone cleaning the code up, but I'm not experienced enough to know how to do it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants