-
Couldn't load subscription status.
- Fork 2.2k
Update astrcorp.cpp adding passwords in ASCII format #14271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this to have romset ID formats, not game names. They may have changed passwords between revisions.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astro uses stable passwords across all versions of each game — I’ve never come across anything different.
This applies even to versions made for different regions: international, U.S.-only, European, or even Russian releases.
So, in the settings, the user simply selects one of the 8 available options:
0 means no password, and 1–7 correspond to the preset passwords already programmed for each game.
If I ever find a version that behaves differently, I’ll make sure to mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a QA thing: we prefer using romset IDs so it's easier to track down when the next guy touches this driver. If you are positive about being identical between revisions then the parent set is fine, but this needs to be noted too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned earlier, this has nothing to do with the ROM set IDs.
For example, the codes for Monkey Land can be used across all sets and all versions.
I’m not sure how to make it any clearer — I’ve handled dozens of boards from different countries, and they all had the same codes.
Personally, it doesn’t really matter to me since I have all the manuals.
So, if you simply don’t want this information included for the users, just let me know and I’ll close the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, Ra's Scepter is already an Astro PC game, not
astrcorp.cpp...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and some games are no dumped yet such Magic 7...