sinclair/specnext_dma.cpp: Implemented prescaler #14296
Open
+61
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb6502
reviewed
Oct 10, 2025
| u16 m_addressB; | ||
| u16 m_count; | ||
| u16 m_byte_counter; | ||
| int m_dma_seq; |
There was a problem hiding this comment.
Is this really externally visible, or is this some specific specnext thing? In the latter case I'd prefer there be a derived device that exposes this via an accessor function instead of just having it out there for all Z80DMA users.
There was a problem hiding this comment.
it's not externally but 'protected', made it visible for the next's child
Is this really externally visible, or is this some specific specnext thing? In the latter case I'd prefer there be a derived device that exposes this via an accessor function instead of just having it out there for all Z80DMA users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.