skeleton/st25.cpp: New systems marked not working #14605
+521
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MooglyGuy
requested changes
Dec 13, 2025
Contributor
MooglyGuy
left a comment
MooglyGuy
left a comment
There was a problem hiding this comment.
Some fairly minor things that would be nice to have before this goes in - otherwise, looks great!
|
|
||
| void st25_state::io_map(address_map &map) | ||
| { | ||
| //OUT |
Contributor
There was a problem hiding this comment.
If these aren't hooked up yet, it would be better to describe the not-yet-hooked outputs in a comment block at the top of the function, rather than a series of commented-out lines.
Contributor
Author
There was a problem hiding this comment.
I think this makes it easier to toggle them on/off during development.
0x3000 is not commented out because it spams the machine log really bad and I've been using the comments like that when I was trying to figure things out (didn't get very far).
cuavas
reviewed
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New systems marked not working
Blizzard [stonedDiscord]
Tango [stonedDiscord]
Tobago [stonedDiscord]
Ballermann 6 [stonedDiscord]
Unimint Arena [stonedDiscord]
City Tower [stonedDiscord]
Jamaica [stonedDiscord]
Majesto [stonedDiscord]
Pur Pur Royal [stonedDiscord]
Robin [stonedDiscord]
Big Action 3000 E [stonedDiscord]
Super Take Off E [stonedDiscord]
Booster Speed [stonedDiscord]
Colossos [stonedDiscord]
Matrixx [stonedDiscord]
Avanti [stonedDiscord]
Rotamint Macao [stonedDiscord]
Multiclassic [stonedDiscord]
Rotamint Alpha [stonedDiscord]
Super Pasch [stonedDiscord]
Big Kick [stonedDiscord]
Galaktica [stonedDiscord]
Amarillo [stonedDiscord]
Xeno [stonedDiscord]